| Message ID | 20180518134705.12533-1-daniels@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 18, 2018 at 02:47:03PM +0100, Daniel Stone wrote: > We cannot create a framebuffer with no objects, so there's no point > testing for it. > > v2: Remove the error entirely. (Sean, CK, Thierry) > > Signed-off-by: Daniel Stone <daniels@collabora.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: Thierry Reding <treding@nvidia.com> > Cc: CK Hu <ck.hu@mediatek.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 ----- > 1 file changed, 5 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Fri, 2018-05-18 at 14:47 +0100, Daniel Stone wrote: > We cannot create a framebuffer with no objects, so there's no point > testing for it. > > v2: Remove the error entirely. (Sean, CK, Thierry) > Reviewed-by: CK Hu <ck.hu@mediatek.com> > Signed-off-by: Daniel Stone <daniels@collabora.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: Thierry Reding <treding@nvidia.com> > Cc: CK Hu <ck.hu@mediatek.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index 2f4b0ffee598..149fc4372917 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -95,11 +95,6 @@ static int mtk_plane_atomic_check(struct drm_plane *plane, > if (!fb) > return 0; > > - if (!mtk_fb_get_gem_obj(fb)) { > - DRM_DEBUG_KMS("buffer is null\n"); > - return -EFAULT; > - } > - > if (!state->crtc) > return 0; >
Hi, Daniel: For the series, applied to mediatek-drm-next-4.19 [1]. [1] https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-4.19 Regards, CK On Fri, 2018-05-18 at 14:47 +0100, Daniel Stone wrote: > We cannot create a framebuffer with no objects, so there's no point > testing for it. > > v2: Remove the error entirely. (Sean, CK, Thierry) > > Signed-off-by: Daniel Stone <daniels@collabora.com> > Cc: Sean Paul <seanpaul@chromium.org> > Cc: Thierry Reding <treding@nvidia.com> > Cc: CK Hu <ck.hu@mediatek.com> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index 2f4b0ffee598..149fc4372917 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -95,11 +95,6 @@ static int mtk_plane_atomic_check(struct drm_plane *plane, > if (!fb) > return 0; > > - if (!mtk_fb_get_gem_obj(fb)) { > - DRM_DEBUG_KMS("buffer is null\n"); > - return -EFAULT; > - } > - > if (!state->crtc) > return 0; >
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index 2f4b0ffee598..149fc4372917 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -95,11 +95,6 @@ static int mtk_plane_atomic_check(struct drm_plane *plane, if (!fb) return 0; - if (!mtk_fb_get_gem_obj(fb)) { - DRM_DEBUG_KMS("buffer is null\n"); - return -EFAULT; - } - if (!state->crtc) return 0;
We cannot create a framebuffer with no objects, so there's no point testing for it. v2: Remove the error entirely. (Sean, CK, Thierry) Signed-off-by: Daniel Stone <daniels@collabora.com> Cc: Sean Paul <seanpaul@chromium.org> Cc: Thierry Reding <treding@nvidia.com> Cc: CK Hu <ck.hu@mediatek.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 ----- 1 file changed, 5 deletions(-)