| Message ID | 20180509154338.2841-1-lukma@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, May 9, 2018 at 10:43 AM, Lukasz Majewski <lukma@denx.de> wrote: > This commit adds support for KOE's 5.7" display. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Please add ack/reviewed-by's when posting new versions. Rob
Hi Thierry, > This commit adds support for KOE's 5.7" display. > Thierry, shall I perform some more work on this code, or is it eligible for applying to your tree? Best regards, Łukasz > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 > ++++++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 26 > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > > diff --git > a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > new file mode 100644 index 000000000000..be7ac666807b --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x > 240) TFT LCD panel + > +Required properties: > +- compatible: should be "koe,tx14d24vm1bpa" > +- backlight: phandle of the backlight device attached to the panel > +- power-supply: single regulator to provide the supply voltage > + > +Required nodes: > +- port: Parallel port mapping to connect this display > + > +This panel needs single power supply voltage. Its backlight is > conntrolled +via PWM signal. > + > +Example: > +-------- > + > +Example device-tree definition when connected to iMX53 based board > + > + lcd_panel: lcd-panel { > + compatible = "koe,tx14d24vm1bpa"; > + backlight = <&backlight_lcd>; > + power-supply = <®_3v3>; > + > + port { > + lcd_panel_in: endpoint { > + remote-endpoint = <&lcd_display_out>; > + }; > + }; > + }; > + > +Then one needs to extend the dispX node: > + > + lcd_display: disp1 { > + > + port@1 { > + reg = <1>; > + > + lcd_display_out: endpoint { > + remote-endpoint = <&lcd_panel_in>; > + }; > + }; > + }; > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c index > d9984bdb5bb5..103b43ce7dee 100644 --- > a/drivers/gpu/drm/panel/panel-simple.c +++ > b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static > const struct panel_desc innolux_zj070na_01p = { }, > }; > > +static const struct display_timing koe_tx14d24vm1bpa_timing = { > + .pixelclock = { 5580000, 5850000, 6200000 }, > + .hactive = { 320, 320, 320 }, > + .hfront_porch = { 30, 30, 30 }, > + .hback_porch = { 30, 30, 30 }, > + .hsync_len = { 1, 5, 17 }, > + .vactive = { 240, 240, 240 }, > + .vfront_porch = { 6, 6, 6 }, > + .vback_porch = { 5, 5, 5 }, > + .vsync_len = { 1, 2, 11 }, > + .flags = DISPLAY_FLAGS_DE_HIGH, > +}; > + > +static const struct panel_desc koe_tx14d24vm1bpa = { > + .timings = &koe_tx14d24vm1bpa_timing, > + .num_timings = 1, > + .bpc = 6, > + .size = { > + .width = 115, > + .height = 86, > + }, > +}; > + > static const struct display_timing koe_tx31d200vm0baa_timing = { > .pixelclock = { 39600000, 43200000, 48000000 }, > .hactive = { 1280, 1280, 1280 }, > @@ -2204,6 +2227,9 @@ static const struct of_device_id > platform_of_match[] = { .compatible = "innolux,zj070na-01p", > .data = &innolux_zj070na_01p, > }, { > + .compatible = "koe,tx14d24vm1bpa", > + .data = &koe_tx14d24vm1bpa, > + }, { > .compatible = "koe,tx31d200vm0baa", > .data = &koe_tx31d200vm0baa, > }, { Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Hi, > Hi Thierry, > > > This commit adds support for KOE's 5.7" display. > > > > Thierry, shall I perform some more work on this code, or is it > eligible for applying to your tree? Gentle ping. If Thierry is overworked - maybe there is a co-maintainer so he/she could apply this patch? > > Best regards, > Łukasz > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > --- > > .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 > > ++++++++++++++++++++++ > > drivers/gpu/drm/panel/panel-simple.c | 26 > > ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 > > Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > > > > diff --git > > a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > > new file mode 100644 index 000000000000..be7ac666807b --- /dev/null > > +++ > > b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt > > @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x > > 240) TFT LCD panel + > > +Required properties: > > +- compatible: should be "koe,tx14d24vm1bpa" > > +- backlight: phandle of the backlight device attached to the panel > > +- power-supply: single regulator to provide the supply voltage > > + > > +Required nodes: > > +- port: Parallel port mapping to connect this display > > + > > +This panel needs single power supply voltage. Its backlight is > > conntrolled +via PWM signal. > > + > > +Example: > > +-------- > > + > > +Example device-tree definition when connected to iMX53 based board > > + > > + lcd_panel: lcd-panel { > > + compatible = "koe,tx14d24vm1bpa"; > > + backlight = <&backlight_lcd>; > > + power-supply = <®_3v3>; > > + > > + port { > > + lcd_panel_in: endpoint { > > + remote-endpoint = > > <&lcd_display_out>; > > + }; > > + }; > > + }; > > + > > +Then one needs to extend the dispX node: > > + > > + lcd_display: disp1 { > > + > > + port@1 { > > + reg = <1>; > > + > > + lcd_display_out: endpoint { > > + remote-endpoint = <&lcd_panel_in>; > > + }; > > + }; > > + }; > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > b/drivers/gpu/drm/panel/panel-simple.c index > > d9984bdb5bb5..103b43ce7dee 100644 --- > > a/drivers/gpu/drm/panel/panel-simple.c +++ > > b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static > > const struct panel_desc innolux_zj070na_01p = { }, > > }; > > > > +static const struct display_timing koe_tx14d24vm1bpa_timing = { > > + .pixelclock = { 5580000, 5850000, 6200000 }, > > + .hactive = { 320, 320, 320 }, > > + .hfront_porch = { 30, 30, 30 }, > > + .hback_porch = { 30, 30, 30 }, > > + .hsync_len = { 1, 5, 17 }, > > + .vactive = { 240, 240, 240 }, > > + .vfront_porch = { 6, 6, 6 }, > > + .vback_porch = { 5, 5, 5 }, > > + .vsync_len = { 1, 2, 11 }, > > + .flags = DISPLAY_FLAGS_DE_HIGH, > > +}; > > + > > +static const struct panel_desc koe_tx14d24vm1bpa = { > > + .timings = &koe_tx14d24vm1bpa_timing, > > + .num_timings = 1, > > + .bpc = 6, > > + .size = { > > + .width = 115, > > + .height = 86, > > + }, > > +}; > > + > > static const struct display_timing koe_tx31d200vm0baa_timing = { > > .pixelclock = { 39600000, 43200000, 48000000 }, > > .hactive = { 1280, 1280, 1280 }, > > @@ -2204,6 +2227,9 @@ static const struct of_device_id > > platform_of_match[] = { .compatible = "innolux,zj070na-01p", > > .data = &innolux_zj070na_01p, > > }, { > > + .compatible = "koe,tx14d24vm1bpa", > > + .data = &koe_tx14d24vm1bpa, > > + }, { > > .compatible = "koe,tx31d200vm0baa", > > .data = &koe_tx31d200vm0baa, > > }, { > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote: > Hi, > > > Hi Thierry, > > > > > This commit adds support for KOE's 5.7" display. > > > > > > > Thierry, shall I perform some more work on this code, or is it > > eligible for applying to your tree? > > Gentle ping. If Thierry is overworked - maybe there is a co-maintainer > so he/she could apply this patch? Please use the proper prefix for the commit subject to increase the chances of this being noticed. This is also still missing a Reviewed-by or Acked-by from Rob. Thierry
Hi Thierry, > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote: > > Hi, > > > > > Hi Thierry, > > > > > > > This commit adds support for KOE's 5.7" display. > > > > > > > > > > Thierry, shall I perform some more work on this code, or is it > > > eligible for applying to your tree? > > > > Gentle ping. If Thierry is overworked - maybe there is a > > co-maintainer so he/she could apply this patch? > > Please use the proper prefix for the commit subject to increase the > chances of this being noticed. Ok. Is there any list of prefixes in the kernel repository, so I could look for them (like get_prefix.py - similar to get_maintainer script)? I've used "display: panel" prefix, but I should have used "drm/panel" > > This is also still missing a Reviewed-by or Acked-by from Rob. Rob has already reviewed this patch. I will send v2 with Rob's Reviewed-by tag. > > Thierry Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote: > Hi Thierry, > > > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote: > > > Hi, > > > > > > > Hi Thierry, > > > > > > > > > This commit adds support for KOE's 5.7" display. > > > > > > > > > > > > > Thierry, shall I perform some more work on this code, or is it > > > > eligible for applying to your tree? > > > > > > Gentle ping. If Thierry is overworked - maybe there is a > > > co-maintainer so he/she could apply this patch? > > > > Please use the proper prefix for the commit subject to increase the > > chances of this being noticed. > > Ok. Is there any list of prefixes in the kernel repository, so I could > look for them (like get_prefix.py - similar to get_maintainer script)? I don't think there is. A good rule of thumb that I use is to go over the git log for the last couple of commits and see if there's a clear pattern. This doesn't work for every subsystem, but drm/panel is very consistent in this regard, on purpose. > I've used "display: panel" prefix, but I should have used "drm/panel" > > > > > This is also still missing a Reviewed-by or Acked-by from Rob. > > Rob has already reviewed this patch. I will send v2 > with Rob's Reviewed-by tag. Okay, I'll apply that v2 then. Thanks, Thierry
Hi Thierry, > On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote: > > Hi Thierry, > > > > > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote: > > > > Hi, > > > > > > > > > Hi Thierry, > > > > > > > > > > > This commit adds support for KOE's 5.7" display. > > > > > > > > > > > > > > > > Thierry, shall I perform some more work on this code, or is it > > > > > eligible for applying to your tree? > > > > > > > > Gentle ping. If Thierry is overworked - maybe there is a > > > > co-maintainer so he/she could apply this patch? > > > > > > Please use the proper prefix for the commit subject to increase > > > the chances of this being noticed. > > > > Ok. Is there any list of prefixes in the kernel repository, so I > > could look for them (like get_prefix.py - similar to get_maintainer > > script)? > > I don't think there is. A good rule of thumb that I use is to go over > the git log for the last couple of commits and see if there's a clear > pattern. This doesn't work for every subsystem, but drm/panel is very > consistent in this regard, on purpose. I see. Is the DRM/panel tree hosted on git.kernel.org? The tree maintained by you there seems to be: kernel/git/thierry.reding/linux-pwm.git IIRC it is hosted elsewhere. Am I right? > > > I've used "display: panel" prefix, but I should have used > > "drm/panel" > > > > > > This is also still missing a Reviewed-by or Acked-by from Rob. > > > > Rob has already reviewed this patch. I will send v2 > > with Rob's Reviewed-by tag. > > Okay, I'll apply that v2 then. Thanks. > > Thanks, > Thierry Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On Tue, May 29, 2018 at 05:33:38PM +0200, Lukasz Majewski wrote: > Hi Thierry, > > > On Tue, May 29, 2018 at 05:01:48PM +0200, Lukasz Majewski wrote: > > > Hi Thierry, > > > > > > > On Mon, May 28, 2018 at 09:55:19AM +0200, Lukasz Majewski wrote: > > > > > Hi, > > > > > > > > > > > Hi Thierry, > > > > > > > > > > > > > This commit adds support for KOE's 5.7" display. > > > > > > > > > > > > > > > > > > > Thierry, shall I perform some more work on this code, or is it > > > > > > eligible for applying to your tree? > > > > > > > > > > Gentle ping. If Thierry is overworked - maybe there is a > > > > > co-maintainer so he/she could apply this patch? > > > > > > > > Please use the proper prefix for the commit subject to increase > > > > the chances of this being noticed. > > > > > > Ok. Is there any list of prefixes in the kernel repository, so I > > > could look for them (like get_prefix.py - similar to get_maintainer > > > script)? > > > > I don't think there is. A good rule of thumb that I use is to go over > > the git log for the last couple of commits and see if there's a clear > > pattern. This doesn't work for every subsystem, but drm/panel is very > > consistent in this regard, on purpose. > > I see. > > Is the DRM/panel tree hosted on git.kernel.org? > > The tree maintained by you there seems to be: > kernel/git/thierry.reding/linux-pwm.git > > IIRC it is hosted elsewhere. Am I right? drm/panel is part of drm-misc: https://cgit.freedesktop.org/drm/drm-misc/ Thierry
diff --git a/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt new file mode 100644 index 000000000000..be7ac666807b --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt @@ -0,0 +1,42 @@ +Kaohsiung Opto-Electronics Inc. 5.7" QVGA (320 x 240) TFT LCD panel + +Required properties: +- compatible: should be "koe,tx14d24vm1bpa" +- backlight: phandle of the backlight device attached to the panel +- power-supply: single regulator to provide the supply voltage + +Required nodes: +- port: Parallel port mapping to connect this display + +This panel needs single power supply voltage. Its backlight is conntrolled +via PWM signal. + +Example: +-------- + +Example device-tree definition when connected to iMX53 based board + + lcd_panel: lcd-panel { + compatible = "koe,tx14d24vm1bpa"; + backlight = <&backlight_lcd>; + power-supply = <®_3v3>; + + port { + lcd_panel_in: endpoint { + remote-endpoint = <&lcd_display_out>; + }; + }; + }; + +Then one needs to extend the dispX node: + + lcd_display: disp1 { + + port@1 { + reg = <1>; + + lcd_display_out: endpoint { + remote-endpoint = <&lcd_panel_in>; + }; + }; + }; diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index d9984bdb5bb5..103b43ce7dee 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1268,6 +1268,29 @@ static const struct panel_desc innolux_zj070na_01p = { }, }; +static const struct display_timing koe_tx14d24vm1bpa_timing = { + .pixelclock = { 5580000, 5850000, 6200000 }, + .hactive = { 320, 320, 320 }, + .hfront_porch = { 30, 30, 30 }, + .hback_porch = { 30, 30, 30 }, + .hsync_len = { 1, 5, 17 }, + .vactive = { 240, 240, 240 }, + .vfront_porch = { 6, 6, 6 }, + .vback_porch = { 5, 5, 5 }, + .vsync_len = { 1, 2, 11 }, + .flags = DISPLAY_FLAGS_DE_HIGH, +}; + +static const struct panel_desc koe_tx14d24vm1bpa = { + .timings = &koe_tx14d24vm1bpa_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 115, + .height = 86, + }, +}; + static const struct display_timing koe_tx31d200vm0baa_timing = { .pixelclock = { 39600000, 43200000, 48000000 }, .hactive = { 1280, 1280, 1280 }, @@ -2204,6 +2227,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "innolux,zj070na-01p", .data = &innolux_zj070na_01p, }, { + .compatible = "koe,tx14d24vm1bpa", + .data = &koe_tx14d24vm1bpa, + }, { .compatible = "koe,tx31d200vm0baa", .data = &koe_tx31d200vm0baa, }, {
This commit adds support for KOE's 5.7" display. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- .../bindings/display/panel/koe,tx14d24vm1bpa.txt | 42 ++++++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/koe,tx14d24vm1bpa.txt