| Message ID | 1521602391-30356-4-git-send-email-aisheng.dong@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dong,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on clk/clk-next]
[also build test ERROR on v4.16-rc6 next-20180322]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dong-Aisheng/clk-new-APIs-to-handle-all-available-clocks/20180323-122451
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
In file included from include/linux/cpufreq.h:14:0,
from arch/powerpc/platforms/cell/cpufreq_spudemand.c:23:
include/linux/clk.h:679:1: error: expected identifier or '(' before '{' token
{
^
>> include/linux/clk.h:677:32: error: 'devm_clk_bulk_get_all' declared 'static' but never defined [-Werror=unused-function]
static inline int __must_check devm_clk_bulk_get_all(struct device *dev,
^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
vim +677 include/linux/clk.h
676
> 677 static inline int __must_check devm_clk_bulk_get_all(struct device *dev,
678 struct clk_bulk_data **clks);
> 679 {
680
681 return 0;
682 }
683
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
> -----Original Message----- > From: kbuild test robot [mailto:lkp@intel.com] > Sent: Friday, March 23, 2018 2:49 PM > To: A.s. Dong <aisheng.dong@nxp.com> > Cc: kbuild-all@01.org; linux-clk@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > mturquette@baylibre.com; hdegoede@redhat.com; > b.zolnierkie@samsung.com; linux@armlinux.org.uk; linux- > fbdev@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; > sboyd@kernel.org; A.s. Dong <aisheng.dong@nxp.com>; Stephen Boyd > <sboyd@codeaurora.org> > Subject: Re: [PATCH V2 3/4] clk: add managed version of clk_bulk_get_all > [...] > All errors (new ones prefixed by >>): > > In file included from include/linux/cpufreq.h:14:0, > from arch/powerpc/platforms/cell/cpufreq_spudemand.c:23: > include/linux/clk.h:679:1: error: expected identifier or '(' before '{' token > { > ^ > >> include/linux/clk.h:677:32: error: 'devm_clk_bulk_get_all' declared > >> 'static' but never defined [-Werror=unused-function] > static inline int __must_check devm_clk_bulk_get_all(struct device *dev, > ^~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > vim +677 include/linux/clk.h > > 676 > > 677 static inline int __must_check devm_clk_bulk_get_all(struct device > *dev, > 678 struct > clk_bulk_data **clks); Thanks for the reporting. Caused by the extra unneeded ';' at the end of the line. Will fix. Regards Dong Aisheng > > 679 { > 680 > 681 return 0; > 682 } > 683 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.01.org%2Fpipermail%2Fkbuild- > all&data=02%7C01%7Caisheng.dong%40nxp.com%7Ce9e35f96c61a4c46d1790 > 8d5908a4d46%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6365738 > 46071200287&sdata=yIWEjcpE2tyJP%2BmsMPqn%2F83TCsxw64J%2Ba5ue73 > qGnN0%3D&reserved=0 Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index d854e26..6d3ca5e 100644 --- a/drivers/clk/clk-devres.c +++ b/drivers/clk/clk-devres.c @@ -70,6 +70,30 @@ int __must_check devm_clk_bulk_get(struct device *dev, int num_clks, } EXPORT_SYMBOL_GPL(devm_clk_bulk_get); +int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks) +{ + struct clk_bulk_devres *devres; + int ret; + + devres = devres_alloc(devm_clk_bulk_release, + sizeof(*devres), GFP_KERNEL); + if (!devres) + return -ENOMEM; + + ret = clk_bulk_get_all(dev, clks); + if (ret > 0) { + devres->clks = *clks; + devres->num_clks = ret; + devres_add(dev, devres); + } else { + devres_free(devres); + } + + return ret; +} +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all); + static int devm_clk_match(struct device *dev, void *res, void *data) { struct clk **c = res; diff --git a/include/linux/clk.h b/include/linux/clk.h index a76fdff..fe48e01 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h @@ -313,6 +313,22 @@ int __must_check clk_bulk_get_all(struct device *dev, */ int __must_check devm_clk_bulk_get(struct device *dev, int num_clks, struct clk_bulk_data *clks); +/** + * devm_clk_bulk_get_all - managed get multiple clk consumers + * @dev: device for clock "consumer" + * @clks: pointer to the clk_bulk_data table of consumer + * + * Returns a positive value for the number of clocks obtained while the + * clock references are stored in the clk_bulk_data table in @clks field. + * Returns 0 if there're none and a negative value if something failed. + * + * This helper function allows drivers to get several clk + * consumers in one operation with management, the clks will + * automatically be freed when the device is unbound. + */ + +int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks); /** * devm_clk_get - lookup and obtain a managed reference to a clock producer. @@ -658,6 +674,13 @@ static inline int __must_check devm_clk_bulk_get(struct device *dev, int num_clk return 0; } +static inline int __must_check devm_clk_bulk_get_all(struct device *dev, + struct clk_bulk_data **clks); +{ + + return 0; +} + static inline struct clk *devm_get_clk_from_child(struct device *dev, struct device_node *np, const char *con_id) {
This patch introduces the managed version of clk_bulk_get_all. Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- v1->v2: * new patch --- drivers/clk/clk-devres.c | 24 ++++++++++++++++++++++++ include/linux/clk.h | 23 +++++++++++++++++++++++ 2 files changed, 47 insertions(+)