[02/13] block: introduce bio_issue_as_root_blkg

Commit Message

Josef Bacik May 29, 2018, 9:17 p.m. UTC

From: Josef Bacik <[e-mail]>

Instead of forcing all file systems to get the right context on their
bio's, simply check for REQ_META to see if we need to issue as the root
blkg.  We don't want to force all bio's to have the root blkg associated
with them if REQ_META is set, as some controllers (blk-iolatency) need
to know who the originating cgroup is so it can backcharge them for the
work they are doing.  This helper will make sure that the controllers do
the proper thing wrt the IO priority and backcharging.

Signed-off-by: Josef Bacik <[e-mail]>
---
 include/linux/blk-cgroup.h | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Tejun Heo May 30, 2018, 3:53 p.m. UTC | #1

On Tue, May 29, 2018 at 05:17:13PM -0400, Josef Bacik wrote:
> From: Josef Bacik <[e-mail]>
> 
> Instead of forcing all file systems to get the right context on their
> bio's, simply check for REQ_META to see if we need to issue as the root
> blkg.  We don't want to force all bio's to have the root blkg associated
> with them if REQ_META is set, as some controllers (blk-iolatency) need
> to know who the originating cgroup is so it can backcharge them for the
> work they are doing.  This helper will make sure that the controllers do
> the proper thing wrt the IO priority and backcharging.
> 
> Signed-off-by: Josef Bacik <[e-mail]>

Acked-by: Tejun Heo <[e-mail]>

Thanks.

Patch

diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h
index 6c666fd7de3c..69aa71dc0c04 100644
--- a/include/linux/blk-cgroup.h
+++ b/include/linux/blk-cgroup.h
@@ -238,6 +238,22 @@  static inline struct blkcg *bio_blkcg(struct bio *bio)
 	return css_to_blkcg(task_css(current, io_cgrp_id));
 }
 
+/**
+ * bio_issue_as_root_blkg - see if this bio needs to be issued as root blkg
+ * @return: true if this bio needs to be submitted with the root blkg context.
+ *
+ * In order to avoid priority inversions we sometimes need to issue a bio as if
+ * it were attached to the root blkg, and then backcharge to the actual owning
+ * blkg.  The idea is we do bio_blkcg() to look up the actual context for the
+ * bio and attach the appropriate blkg to the bio.  Then we call this helper and
+ * if it is true run with the root blkg for that queue and then do any
+ * backcharging to the originating cgroup once the io is complete.
+ */
+static inline bool bio_issue_as_root_blkg(struct bio *bio)
+{
+	return (bio->bi_opf & REQ_META);
+}
+
 /**
  * blkcg_parent - get the parent of a blkcg
  * @blkcg: blkcg of interest