| Message ID | da121dede6d79460c5653a5bc360d413cb988c74.1528117485.git.matti.vaittinen@fi.rohmeurope.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Jun 04, 2018 at 04:18:53PM +0300, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC clock output. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > .../bindings/clock/rohm,bd71837-clock.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > > diff --git a/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > new file mode 100644 > index 000000000000..771acfe34114 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > @@ -0,0 +1,38 @@ > +ROHM BD71837 Power Management Integrated Circuit clock bindings This needs to be added to the MFD doc. One node should be covered by at most 1 document. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 05, 2018 at 09:49:32AM -0600, Rob Herring wrote: > On Mon, Jun 04, 2018 at 04:18:53PM +0300, Matti Vaittinen wrote: > > Document devicetree bindings for ROHM BD71837 PMIC clock output. > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > > --- > > .../bindings/clock/rohm,bd71837-clock.txt | 38 ++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > > > > diff --git a/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > > new file mode 100644 > > index 000000000000..771acfe34114 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt > > @@ -0,0 +1,38 @@ > > +ROHM BD71837 Power Management Integrated Circuit clock bindings > > This needs to be added to the MFD doc. One node should be covered by at > most 1 document. I was thinking of that too. But then I asked why? I also thought that if one knows there is clock block in the chip - where does he look for binding document? From clock folder. Then I saw how bindings for MAX77686 chip were written and thought that this is beneficial for all. MFD document directs to clock and regulator docs and on othe other hand, clock document clearly states that properties it describes must be present "in main device node of the MFD chip". Don't you think on searching for clock bindings should find something from clock folder? I can follow your instruction here but I think the user might be happy if he found something under bindings/clock for clock related properties. Br, Matti Vaittinen -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt new file mode 100644 index 000000000000..771acfe34114 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt @@ -0,0 +1,38 @@ +ROHM BD71837 Power Management Integrated Circuit clock bindings + +This is a part of device tree bindings of ROHM BD71837 multi-function +device. See generic BD71837 MFD bindings at: + Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.txt + +BD71837 contains one 32,768 KHz clock output which can be enabled and +disabled via i2c. + +Following properties should be present in main device node of the MFD chip. + +Required properties: +- clock-frequency : Should be 32768 +- #clock-cells : Should be 0 + +Optional properties: +- clock-output-names : Should contain name for output clock. + +Example: + +/* MFD node */ + +pmic: pmic@4b { + compatible = "rohm,bd71837"; + /* ... */ + #clock-cells = <0>; + clock-frequency = <32768>; + /* ... */ +}; + +/* Clock consumer node */ + +foo@0 { + compatible = "bar,foo"; + /* ... */ + clock-names = "my-clock"; + clocks = <&pmic>; +};
Document devicetree bindings for ROHM BD71837 PMIC clock output. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- .../bindings/clock/rohm,bd71837-clock.txt | 38 ++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/rohm,bd71837-clock.txt