diff mbox

[xf86-video-intel] sna/video/sprite: Remove the XV_ALWAYS_ON_TOP restriction for SKL+ scaling

Message ID 20180608192835.31788-1-ville.syrjala@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ville Syrjälä June 8, 2018, 7:28 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

On SKL+ the dst colorkey is enabled on the primary plane instead of the
sprite plane. That means the restriction of scaling vs. keying doesn't
actually apply here as we never scale the primary. So let's remove
the requirement of having XV_ALWAYS_ON_TOP enabled to get hw scaling.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 src/sna/sna_video_sprite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson June 9, 2018, 1:11 p.m. UTC | #1 
Quoting Ville Syrjala (2018-06-08 20:28:35)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> On SKL+ the dst colorkey is enabled on the primary plane instead of the
> sprite plane. That means the restriction of scaling vs. keying doesn't
> actually apply here as we never scale the primary. So let's remove
> the requirement of having XV_ALWAYS_ON_TOP enabled to get hw scaling.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Ok :) Pushed,
-Chris
diff mbox

Patch

diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c
index f713abcb9151..8b7ae8ae9e75 100644
--- a/src/sna/sna_video_sprite.c
+++ b/src/sna/sna_video_sprite.c
@@ -49,7 +49,7 @@ 
 #define DRM_FORMAT_NV12         fourcc_code('N', 'V', '1', '2') /* 2x2 subsampled Cr:Cb plane */
 
 #define has_hw_scaling(sna, video) ((sna)->kgem.gen < 071 || \
-				    ((sna)->kgem.gen >= 0110 && (video)->AlwaysOnTop))
+				    (sna)->kgem.gen >= 0110)
 
 
 #define LOCAL_IOCTL_MODE_SETPLANE	DRM_IOWR(0xB7, struct local_mode_set_plane)