| Message ID | b55024472e101a33b3d6b098aa2ce23c5b5dd6f7.1528819790.git.dolinux.peng@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
...instead of open coding file operations followed by custom ->open() callbacks per each attribute. Peng Donglin (2): ARM: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro ARM64: dump: Convert to use DEFINE_SHOW_ATTRIBUTE macro arch/arm/mm/ptdump_debugfs.c | 13 +------------ arch/arm64/mm/ptdump_debugfs.c | 13 +------------ 2 files changed, 2 insertions(+), 24 deletions(-)
On Wed, Jun 13, 2018 at 9:15 AM Peng Donglin <dolinux.peng@gmail.com> wrote: > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> > --- > arch/arm/mm/ptdump_debugfs.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c > index be8d87b..79002fe 100644 > --- a/arch/arm/mm/ptdump_debugfs.c > +++ b/arch/arm/mm/ptdump_debugfs.c > @@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v) > ptdump_walk_pgd(m, info); > return 0; > } > - > -static int ptdump_open(struct inode *inode, struct file *file) > -{ > - return single_open(file, ptdump_show, inode->i_private); > -} > - > -static const struct file_operations ptdump_fops = { > - .open = ptdump_open, > - .read = seq_read, > - .llseek = seq_lseek, > - .release = single_release, > -}; > +DEFINE_SHOW_ATTRIBUTE(ptdump); > > int ptdump_debugfs_register(struct ptdump_info *info, const char *name) > { > -- > 2.7.4 > any suggestion?
diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c index be8d87b..79002fe 100644 --- a/arch/arm/mm/ptdump_debugfs.c +++ b/arch/arm/mm/ptdump_debugfs.c @@ -11,18 +11,7 @@ static int ptdump_show(struct seq_file *m, void *v) ptdump_walk_pgd(m, info); return 0; } - -static int ptdump_open(struct inode *inode, struct file *file) -{ - return single_open(file, ptdump_show, inode->i_private); -} - -static const struct file_operations ptdump_fops = { - .open = ptdump_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(ptdump); int ptdump_debugfs_register(struct ptdump_info *info, const char *name) {
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Peng Donglin <dolinux.peng@gmail.com> --- arch/arm/mm/ptdump_debugfs.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)