diff mbox

drm/i915: make skl plane and planar format tables const

Message ID 20180613114620.7103-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jani Nikula June 13, 2018, 11:46 a.m. UTC 
No reason not to be const.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_sprite.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ville Syrjälä June 13, 2018, 12:23 p.m. UTC | #1 
On Wed, Jun 13, 2018 at 02:46:20PM +0300, Jani Nikula wrote:
> No reason not to be const.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Or we can go with
https://patchwork.freedesktop.org/patch/226880/

> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 344c0e709b19..412782f3b065 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1256,7 +1256,7 @@ static const uint32_t vlv_plane_formats[] = {
>  	DRM_FORMAT_VYUY,
>  };
>  
> -static uint32_t skl_plane_formats[] = {
> +static const uint32_t skl_plane_formats[] = {
>  	DRM_FORMAT_RGB565,
>  	DRM_FORMAT_ABGR8888,
>  	DRM_FORMAT_ARGB8888,
> @@ -1268,7 +1268,7 @@ static uint32_t skl_plane_formats[] = {
>  	DRM_FORMAT_VYUY,
>  };
>  
> -static uint32_t skl_planar_formats[] = {
> +static const uint32_t skl_planar_formats[] = {
>  	DRM_FORMAT_RGB565,
>  	DRM_FORMAT_ABGR8888,
>  	DRM_FORMAT_ARGB8888,
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula June 13, 2018, 12:32 p.m. UTC | #2 
On Wed, 13 Jun 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jun 13, 2018 at 02:46:20PM +0300, Jani Nikula wrote:
>> No reason not to be const.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Or we can go with
> https://patchwork.freedesktop.org/patch/226880/

Fine by me.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/intel_sprite.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
>> index 344c0e709b19..412782f3b065 100644
>> --- a/drivers/gpu/drm/i915/intel_sprite.c
>> +++ b/drivers/gpu/drm/i915/intel_sprite.c
>> @@ -1256,7 +1256,7 @@ static const uint32_t vlv_plane_formats[] = {
>>  	DRM_FORMAT_VYUY,
>>  };
>>  
>> -static uint32_t skl_plane_formats[] = {
>> +static const uint32_t skl_plane_formats[] = {
>>  	DRM_FORMAT_RGB565,
>>  	DRM_FORMAT_ABGR8888,
>>  	DRM_FORMAT_ARGB8888,
>> @@ -1268,7 +1268,7 @@ static uint32_t skl_plane_formats[] = {
>>  	DRM_FORMAT_VYUY,
>>  };
>>  
>> -static uint32_t skl_planar_formats[] = {
>> +static const uint32_t skl_planar_formats[] = {
>>  	DRM_FORMAT_RGB565,
>>  	DRM_FORMAT_ABGR8888,
>>  	DRM_FORMAT_ARGB8888,
>> -- 
>> 2.11.0
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
index 344c0e709b19..412782f3b065 100644
--- a/drivers/gpu/drm/i915/intel_sprite.c
+++ b/drivers/gpu/drm/i915/intel_sprite.c
@@ -1256,7 +1256,7 @@  static const uint32_t vlv_plane_formats[] = {
 	DRM_FORMAT_VYUY,
 };
 
-static uint32_t skl_plane_formats[] = {
+static const uint32_t skl_plane_formats[] = {
 	DRM_FORMAT_RGB565,
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_ARGB8888,
@@ -1268,7 +1268,7 @@  static uint32_t skl_plane_formats[] = {
 	DRM_FORMAT_VYUY,
 };
 
-static uint32_t skl_planar_formats[] = {
+static const uint32_t skl_planar_formats[] = {
 	DRM_FORMAT_RGB565,
 	DRM_FORMAT_ABGR8888,
 	DRM_FORMAT_ARGB8888,