diff mbox

[4/5] drm/i915: Show CCID in engine dumps

Message ID 20180614094103.18025-4-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson June 14, 2018, 9:41 a.m. UTC
For debugging context issues, knowing what context the GPU is
loading/using is helpful.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_engine_cs.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Joonas Lahtinen June 14, 2018, 12:14 p.m. UTC | #1
Quoting Chris Wilson (2018-06-14 12:41:02)
> For debugging context issues, knowing what context the GPU is
> loading/using is helpful.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

On the GPU error state, we capture point blank if INTEL_GEN() >= 5, any
specific reason to differ from there?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
Chris Wilson June 14, 2018, 12:27 p.m. UTC | #2
Quoting Joonas Lahtinen (2018-06-14 13:14:09)
> Quoting Chris Wilson (2018-06-14 12:41:02)
> > For debugging context issues, knowing what context the GPU is
> > loading/using is helpful.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> On the GPU error state, we capture point blank if INTEL_GEN() >= 5, any
> specific reason to differ from there?

That I need to work out what we need to capture for execlists. Is CCID
per-engine on gen8+, although iirc CCID is gone on gen8. Yup, all 0s.

So CCID is not what we want, but we do want something :)
Maybe it's execlists debug status?
-Chris
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
index 875bd466f3bf..5a663dda9fdc 100644
--- a/drivers/gpu/drm/i915/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/intel_engine_cs.c
@@ -1273,6 +1273,8 @@  static void intel_engine_print_registers(const struct intel_engine_cs *engine,
 		&engine->execlists;
 	u64 addr;
 
+	if (engine->id == RCS && IS_GEN(dev_priv, 5, 7))
+		drm_printf(m, "\tCCID: 0x%08x\n", I915_READ(CCID));
 	drm_printf(m, "\tRING_START: 0x%08x\n",
 		   I915_READ(RING_START(engine->mmio_base)));
 	drm_printf(m, "\tRING_HEAD:  0x%08x\n",