| Message ID | 20180519204808.28899-1-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, May 19, 2018 at 3:48 PM Adam Ford <aford173@gmail.com> wrote: > > The AM3517-EVM uses a TPS65023 PMIC. This is already defined > by: compatible = "ti,tps65023" > > There doesn't seem to be a need to have each regulator in the > PMIC with the 'compatible = "regulator-fixed"' since each > regulator has a min and max setting. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Gentle nudge adam > diff --git a/arch/arm/boot/dts/am3517-som.dtsi b/arch/arm/boot/dts/am3517-som.dtsi > index a6d5ff73c163..7ff7cd135dca 100644 > --- a/arch/arm/boot/dts/am3517-som.dtsi > +++ b/arch/arm/boot/dts/am3517-som.dtsi > @@ -64,7 +64,6 @@ > regulators { > vdd_core_reg: VDCDC1 { > regulator-name = "vdd_core"; > - compatible = "regulator-fixed"; > regulator-always-on; > regulator-min-microvolt = <1200000>; > regulator-max-microvolt = <1200000>; > @@ -72,7 +71,6 @@ > > vdd_io_reg: VDCDC2 { > regulator-name = "vdd_io"; > - compatible = "regulator-fixed"; > regulator-always-on; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > @@ -80,7 +78,6 @@ > > vdd_1v8_reg: VDCDC3 { > regulator-name = "vdd_1v8"; > - compatible = "regulator-fixed"; > regulator-always-on; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > @@ -88,7 +85,6 @@ > > vdd_usb18_reg: LDO1 { > regulator-name = "vdd_usb18"; > - compatible = "regulator-fixed"; > regulator-always-on; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <1800000>; > @@ -96,7 +92,6 @@ > > vdd_usb33_reg: LDO2 { > regulator-name = "vdd_usb33"; > - compatible = "regulator-fixed"; > regulator-always-on; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > -- > 2.17.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Adam Ford <aford173@gmail.com> [180619 22:48]: > On Sat, May 19, 2018 at 3:48 PM Adam Ford <aford173@gmail.com> wrote: > > > > The AM3517-EVM uses a TPS65023 PMIC. This is already defined > > by: compatible = "ti,tps65023" > > > > There doesn't seem to be a need to have each regulator in the > > PMIC with the 'compatible = "regulator-fixed"' since each > > regulator has a min and max setting. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > Gentle nudge Sorry for the delay, applying into omap-for-v4.19/dt thanks. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am3517-som.dtsi b/arch/arm/boot/dts/am3517-som.dtsi index a6d5ff73c163..7ff7cd135dca 100644 --- a/arch/arm/boot/dts/am3517-som.dtsi +++ b/arch/arm/boot/dts/am3517-som.dtsi @@ -64,7 +64,6 @@ regulators { vdd_core_reg: VDCDC1 { regulator-name = "vdd_core"; - compatible = "regulator-fixed"; regulator-always-on; regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; @@ -72,7 +71,6 @@ vdd_io_reg: VDCDC2 { regulator-name = "vdd_io"; - compatible = "regulator-fixed"; regulator-always-on; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; @@ -80,7 +78,6 @@ vdd_1v8_reg: VDCDC3 { regulator-name = "vdd_1v8"; - compatible = "regulator-fixed"; regulator-always-on; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; @@ -88,7 +85,6 @@ vdd_usb18_reg: LDO1 { regulator-name = "vdd_usb18"; - compatible = "regulator-fixed"; regulator-always-on; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; @@ -96,7 +92,6 @@ vdd_usb33_reg: LDO2 { regulator-name = "vdd_usb33"; - compatible = "regulator-fixed"; regulator-always-on; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>;
The AM3517-EVM uses a TPS65023 PMIC. This is already defined by: compatible = "ti,tps65023" There doesn't seem to be a need to have each regulator in the PMIC with the 'compatible = "regulator-fixed"' since each regulator has a min and max setting. Signed-off-by: Adam Ford <aford173@gmail.com>