| Message ID | 20180619131332.23741-1-daniel@zonque.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Daniel Mack <daniel@zonque.org> writes: > When parsing the video modes from DT properties, make sure to zero out > memory befor using it. This is important because not all fields in the mode s/befor/before/ This taken care of ... Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, June 19, 2018 10:11 PM, Robert Jarzmik wrote: > Daniel Mack <daniel@zonque.org> writes: > >> When parsing the video modes from DT properties, make sure to zero out >> memory befor using it. This is important because not all fields in the mode > s/befor/before/ > Yeah, seen this too after sending. Should I resend, or can this be amended when applying? > This taken care of ... > Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr> Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Daniel Mack <daniel@zonque.org> writes: > On Tuesday, June 19, 2018 10:11 PM, Robert Jarzmik wrote: >> Daniel Mack <daniel@zonque.org> writes: >> >>> When parsing the video modes from DT properties, make sure to zero out >>> memory befor using it. This is important because not all fields in the mode >> s/befor/before/ >> > > Yeah, seen this too after sending. Should I resend, or can this be amended when > applying? I think this question is for Bartlomiej, as fbdev is his tree ... >> This taken care of ... >> Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr> Cheers.
On Thursday, June 21, 2018 11:22:35 AM Robert Jarzmik wrote: > Daniel Mack <daniel@zonque.org> writes: > > > On Tuesday, June 19, 2018 10:11 PM, Robert Jarzmik wrote: > >> Daniel Mack <daniel@zonque.org> writes: > >> > >>> When parsing the video modes from DT properties, make sure to zero out > >>> memory befor using it. This is important because not all fields in the mode > >> s/befor/before/ > >> > > > > Yeah, seen this too after sending. Should I resend, or can this be amended when > > applying? > I think this question is for Bartlomiej, as fbdev is his tree ... I will fix this typo while applying, no need for resend.. > >> This taken care of ... > >> Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday, June 21, 2018 12:39 PM, Bartlomiej Zolnierkiewicz wrote: > On Thursday, June 21, 2018 11:22:35 AM Robert Jarzmik wrote: >> Daniel Mack <daniel@zonque.org> writes: >> >>> On Tuesday, June 19, 2018 10:11 PM, Robert Jarzmik wrote: >>>> Daniel Mack <daniel@zonque.org> writes: >>>> >>>>> When parsing the video modes from DT properties, make sure to zero out >>>>> memory befor using it. This is important because not all fields in the mode >>>> s/befor/before/ >>>> >>> >>> Yeah, seen this too after sending. Should I resend, or can this be amended when >>> applying? >> I think this question is for Bartlomiej, as fbdev is his tree ... > > I will fix this typo while applying, no need for resend.. Hang on. I have some more patches on top, so I'll resend this one as part of a bigger series soon. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index c2c2e2790079..4752b218fac4 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2130,8 +2130,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, return -EINVAL; ret = -ENOMEM; - info->modes = kmalloc_array(timings->num_timings, - sizeof(info->modes[0]), GFP_KERNEL); + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]), + GFP_KERNEL); if (!info->modes) goto out; info->num_modes = timings->num_timings;
When parsing the video modes from DT properties, make sure to zero out memory befor using it. This is important because not all fields in the mode struct are explicitly initialized, even though they are used later on. Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) Cc: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Daniel Mack <daniel@zonque.org> --- v2: use kcalloc() instead of open-coding the same through kmalloc_array(__GFP_ZERO) drivers/video/fbdev/pxafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)