| Message ID | 1529608199-5583-6-git-send-email-pawel.mikolaj.chmiel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 21 June 2018 at 21:09, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote: > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > index 14510b215480..edce6602de50 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt > @@ -2,6 +2,8 @@ > > Required root node properties: > - compatible = should be one or more of the following. > + - "samsung,aries" - for S5PV210-based Samsung Aries board. > + - "samsung,galaxys" - for S5PV210-based Samsung Galaxy S (i9000) board. It is not strictly speaking Exynos-based board (as mentioned in the header at beginning of file) so maybe change it to "Samsung's Exynos and S5P SoC based boards"? Best regards, Krzysztof > - "samsung,artik5" - for Exynos3250-based Samsung ARTIK5 module. > - "samsung,artik5-eval" - for Exynos3250-based Samsung ARTIK5 eval board. > - "samsung,monk" - for Exynos3250-based Samsung Simband board. > -- > 2.7.4 >
On 22 June 2018 at 09:56, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 21 June 2018 at 21:09, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote: >> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> ... and commit msg please. BR, Krzysztof >> --- >> Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> index 14510b215480..edce6602de50 100644 >> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt >> @@ -2,6 +2,8 @@ >> >> Required root node properties: >> - compatible = should be one or more of the following. >> + - "samsung,aries" - for S5PV210-based Samsung Aries board. >> + - "samsung,galaxys" - for S5PV210-based Samsung Galaxy S (i9000) board. > > It is not strictly speaking Exynos-based board (as mentioned in the > header at beginning of file) so maybe change it to "Samsung's Exynos > and S5P SoC based boards"? > > Best regards, > Krzysztof > >> - "samsung,artik5" - for Exynos3250-based Samsung ARTIK5 module. >> - "samsung,artik5-eval" - for Exynos3250-based Samsung ARTIK5 eval board. >> - "samsung,monk" - for Exynos3250-based Samsung Simband board. >> -- >> 2.7.4 >>
On Thu, Jun 21, 2018 at 09:09:57PM +0200, Paweł Chmiel wrote: > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > --- > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt index 14510b215480..edce6602de50 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt @@ -2,6 +2,8 @@ Required root node properties: - compatible = should be one or more of the following. + - "samsung,aries" - for S5PV210-based Samsung Aries board. + - "samsung,galaxys" - for S5PV210-based Samsung Galaxy S (i9000) board. - "samsung,artik5" - for Exynos3250-based Samsung ARTIK5 module. - "samsung,artik5-eval" - for Exynos3250-based Samsung ARTIK5 eval board. - "samsung,monk" - for Exynos3250-based Samsung Simband board.
Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> --- Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++ 1 file changed, 2 insertions(+)