| Message ID | e5f5f315a882fe5cdd161c8cb1790c9f3de0920a.1529654288.git.baolin.wang@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri 22 Jun 01:09 PDT 2018, Baolin Wang wrote: > Use devm_hwspin_lock_register() to register the hwlock controller to > avoid unregistering the device explicitly. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > drivers/hwspinlock/sprd_hwspinlock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c > index dc42bf5..ba5daf6 100644 > --- a/drivers/hwspinlock/sprd_hwspinlock.c > +++ b/drivers/hwspinlock/sprd_hwspinlock.c > @@ -120,8 +120,9 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, sprd_hwlock); > pm_runtime_enable(&pdev->dev); > > - ret = hwspin_lock_register(&sprd_hwlock->bank, &pdev->dev, > - &sprd_hwspinlock_ops, 0, SPRD_HWLOCKS_NUM); > + ret = devm_hwspin_lock_register(&pdev->dev, &sprd_hwlock->bank, > + &sprd_hwspinlock_ops, 0, > + SPRD_HWLOCKS_NUM); > if (ret) { > pm_runtime_disable(&pdev->dev); > clk_disable_unprepare(sprd_hwlock->clk); > @@ -135,7 +136,6 @@ static int sprd_hwspinlock_remove(struct platform_device *pdev) > { > struct sprd_hwspinlock_dev *sprd_hwlock = platform_get_drvdata(pdev); > > - hwspin_lock_unregister(&sprd_hwlock->bank); Until the hwspinlock is unregistered it's possible for clients to issue operations on it, so disabling power and clocks before that seems bad. Regards, Bjorn > pm_runtime_disable(&pdev->dev); > clk_disable_unprepare(sprd_hwlock->clk); > return 0; > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 27 June 2018 at 04:51, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > On Fri 22 Jun 01:09 PDT 2018, Baolin Wang wrote: > >> Use devm_hwspin_lock_register() to register the hwlock controller to >> avoid unregistering the device explicitly. >> >> Signed-off-by: Baolin Wang <baolin.wang@linaro.org> >> --- >> drivers/hwspinlock/sprd_hwspinlock.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c >> index dc42bf5..ba5daf6 100644 >> --- a/drivers/hwspinlock/sprd_hwspinlock.c >> +++ b/drivers/hwspinlock/sprd_hwspinlock.c >> @@ -120,8 +120,9 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, sprd_hwlock); >> pm_runtime_enable(&pdev->dev); >> >> - ret = hwspin_lock_register(&sprd_hwlock->bank, &pdev->dev, >> - &sprd_hwspinlock_ops, 0, SPRD_HWLOCKS_NUM); >> + ret = devm_hwspin_lock_register(&pdev->dev, &sprd_hwlock->bank, >> + &sprd_hwspinlock_ops, 0, >> + SPRD_HWLOCKS_NUM); >> if (ret) { >> pm_runtime_disable(&pdev->dev); >> clk_disable_unprepare(sprd_hwlock->clk); >> @@ -135,7 +136,6 @@ static int sprd_hwspinlock_remove(struct platform_device *pdev) >> { >> struct sprd_hwspinlock_dev *sprd_hwlock = platform_get_drvdata(pdev); >> >> - hwspin_lock_unregister(&sprd_hwlock->bank); > > Until the hwspinlock is unregistered it's possible for clients to issue > operations on it, so disabling power and clocks before that seems bad. Yes, you are right. So may be register some additional actions with devm core to call the clock disable as appropriate. Thanks.
diff --git a/drivers/hwspinlock/sprd_hwspinlock.c b/drivers/hwspinlock/sprd_hwspinlock.c index dc42bf5..ba5daf6 100644 --- a/drivers/hwspinlock/sprd_hwspinlock.c +++ b/drivers/hwspinlock/sprd_hwspinlock.c @@ -120,8 +120,9 @@ static int sprd_hwspinlock_probe(struct platform_device *pdev) platform_set_drvdata(pdev, sprd_hwlock); pm_runtime_enable(&pdev->dev); - ret = hwspin_lock_register(&sprd_hwlock->bank, &pdev->dev, - &sprd_hwspinlock_ops, 0, SPRD_HWLOCKS_NUM); + ret = devm_hwspin_lock_register(&pdev->dev, &sprd_hwlock->bank, + &sprd_hwspinlock_ops, 0, + SPRD_HWLOCKS_NUM); if (ret) { pm_runtime_disable(&pdev->dev); clk_disable_unprepare(sprd_hwlock->clk); @@ -135,7 +136,6 @@ static int sprd_hwspinlock_remove(struct platform_device *pdev) { struct sprd_hwspinlock_dev *sprd_hwlock = platform_get_drvdata(pdev); - hwspin_lock_unregister(&sprd_hwlock->bank); pm_runtime_disable(&pdev->dev); clk_disable_unprepare(sprd_hwlock->clk); return 0;
Use devm_hwspin_lock_register() to register the hwlock controller to avoid unregistering the device explicitly. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- drivers/hwspinlock/sprd_hwspinlock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)