| Message ID | 1530182744-10731-2-git-send-email-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28/06/2018 12:45, Stanley Chu wrote: > This patch fixes bindings of existed "General Purpose Timer", > and then add bindings of new "System Timer" on Mediatek SoCs. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > .../bindings/timer/mediatek,mtk-timer.txt | 38 ++++++++++++++++---- > 1 file changed, 32 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > index b1fe7e9..d42247b 100644 > --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > @@ -1,5 +1,14 @@ > -Mediatek MT6577, MT6572 and MT6589 Timers > ---------------------------------------- > +Mediatek Timers > +--------------- > + > +Mediatek SoCs have two different timers on different platforms, > +- GPT (General Purpose Timer) > +- SYST (System Timer) > + > +Please bind correct timers in each platforms. > + > + > +** General Purpose Timer (GPT) > > Required properties: > - compatible should contain: > @@ -11,9 +20,8 @@ Required properties: > * "mediatek,mt8135-timer" for MT8135 compatible timers > * "mediatek,mt8173-timer" for MT8173 compatible timers > * "mediatek,mt6577-timer" for MT6577 and all above compatible timers > -- reg: Should contain location and length for timers register. > -- clocks: Clocks driving the timer hardware. This list should include two > - clocks. The order is system clock and as second clock the RTC clock. > +- reg: Should contain location and length for GPT register. > +- clocks: GPT is drived by system clock. > > Examples: > > @@ -21,5 +29,23 @@ Examples: > compatible = "mediatek,mt6577-timer"; > reg = <0x10008000 0x80>; > interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>; > - clocks = <&system_clk>, <&rtc_clk>; > + clocks = <&system_clk>; > + }; > + > + > +** System Timer (SYST) > + > +Required properties: > +- compatible: Should contain > + * "mediatek,mt6765-systimer" for MT6765 compatible timers > +- reg: Should contain the location and length for system timer registers. > +- clocks: System timer is drived by system clock. > + > +Examples: > + > + systimer@10017000 { > + compatible = "mediatek,mt6765-systimer"; why not "mediatek,mt6765-timer" ? for consistency. > + reg = <0 0x10017000 0 0x1000>; > + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&system_clk>; > }; >
On Thu, 2018-06-28 at 16:08 +0200, Daniel Lezcano wrote: > > +** System Timer (SYST) > > + > > +Required properties: > > +- compatible: Should contain > > + * "mediatek,mt6765-systimer" for MT6765 compatible timers > > +- reg: Should contain the location and length for system timer registers. > > +- clocks: System timer is drived by system clock. > > + > > +Examples: > > + > > + systimer@10017000 { > > + compatible = "mediatek,mt6765-systimer"; > > why not "mediatek,mt6765-timer" ? for consistency. > Hi Daniel, The original thought is to remind user to notice that different timer will be used. However it looks more clean if we use consistent name. Will fix it in v4. > > + reg = <0 0x10017000 0 0x1000>; > > + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&system_clk>; > > }; > > > > Thanks. Stanley Chu
diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt index b1fe7e9..d42247b 100644 --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt @@ -1,5 +1,14 @@ -Mediatek MT6577, MT6572 and MT6589 Timers ---------------------------------------- +Mediatek Timers +--------------- + +Mediatek SoCs have two different timers on different platforms, +- GPT (General Purpose Timer) +- SYST (System Timer) + +Please bind correct timers in each platforms. + + +** General Purpose Timer (GPT) Required properties: - compatible should contain: @@ -11,9 +20,8 @@ Required properties: * "mediatek,mt8135-timer" for MT8135 compatible timers * "mediatek,mt8173-timer" for MT8173 compatible timers * "mediatek,mt6577-timer" for MT6577 and all above compatible timers -- reg: Should contain location and length for timers register. -- clocks: Clocks driving the timer hardware. This list should include two - clocks. The order is system clock and as second clock the RTC clock. +- reg: Should contain location and length for GPT register. +- clocks: GPT is drived by system clock. Examples: @@ -21,5 +29,23 @@ Examples: compatible = "mediatek,mt6577-timer"; reg = <0x10008000 0x80>; interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>; - clocks = <&system_clk>, <&rtc_clk>; + clocks = <&system_clk>; + }; + + +** System Timer (SYST) + +Required properties: +- compatible: Should contain + * "mediatek,mt6765-systimer" for MT6765 compatible timers +- reg: Should contain the location and length for system timer registers. +- clocks: System timer is drived by system clock. + +Examples: + + systimer@10017000 { + compatible = "mediatek,mt6765-systimer"; + reg = <0 0x10017000 0 0x1000>; + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&system_clk>; };
This patch fixes bindings of existed "General Purpose Timer", and then add bindings of new "System Timer" on Mediatek SoCs. Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- .../bindings/timer/mediatek,mtk-timer.txt | 38 ++++++++++++++++---- 1 file changed, 32 insertions(+), 6 deletions(-)