| Message ID | 20180618111821.47088-1-michal.wajdeczko@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 18, 2018 at 11:18:20AM +0000, Michal Wajdeczko wrote: > While debugging we may want to examine params passed to GuC. > > v2: drop #ifdef DEBUG_GUC - Michal > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Michel Thierry <michel.thierry@intel.com> > Reviewed-by: Michel Thierry <michel.thierry@intel.com> #1 > Cc: Michal Winiarski <michal.winiarski@intel.com> > --- > drivers/gpu/drm/i915/intel_guc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c > index 1aff30b..feecf6e5 100644 > --- a/drivers/gpu/drm/i915/intel_guc.c > +++ b/drivers/gpu/drm/i915/intel_guc.c > @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc) > params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc); > params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc); > > + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++) > + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]); > + Reviewed-by: Michał Winiarski <michal.winiarski@intel.com> -Michał > /* > * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and > * they are power context saved so it's ok to release forcewake > -- > 1.9.1 >
On Mon, 18 Jun 2018 18:25:21 +0200, Patchwork <patchwork@emeril.freedesktop.org> wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915/guc: Print CTL params > passed to Guc > URL : https://patchwork.freedesktop.org/series/44934/ > State : failure > > == Summary == > > = CI Bug Log - changes from CI_DRM_4334_full -> Patchwork_9351_full = > > == Summary - FAILURE == > > Serious unknown changes coming with Patchwork_9351_full absolutely > need to be > verified manually. > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_9351_full, please notify your bug team to > allow them > to document this new failure mode, which will reduce false positives > in CI. > > > == Possible new issues == > > Here are the unknown changes that may have been introduced in > Patchwork_9351_full: > > === IGT changes === > > ==== Possible regressions ==== > > igt@drv_selftest@mock_contexts: > shard-apl: PASS -> DMESG-FAIL +1 > shard-kbl: PASS -> DMESG-FAIL > shard-snb: PASS -> DMESG-FAIL > shard-hsw: PASS -> DMESG-FAIL > shard-glk: PASS -> DMESG-FAIL > > igt@gem_exec_capture@capture-render: > shard-kbl: PASS -> DMESG-WARN +3 > > igt@pm_rpm@debugfs-read: > shard-apl: PASS -> DMESG-WARN > again, all these issues are the same as with HAX alone - see [1] [1] https://patchwork.freedesktop.org/series/40112/ Michal
Quoting Michał Winiarski (2018-06-18 13:32:47) > On Mon, Jun 18, 2018 at 11:18:20AM +0000, Michal Wajdeczko wrote: > > While debugging we may want to examine params passed to GuC. > > > > v2: drop #ifdef DEBUG_GUC - Michal > > > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > > Cc: Michel Thierry <michel.thierry@intel.com> > > Reviewed-by: Michel Thierry <michel.thierry@intel.com> #1 > > Cc: Michal Winiarski <michal.winiarski@intel.com> > > > --- > > drivers/gpu/drm/i915/intel_guc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c > > index 1aff30b..feecf6e5 100644 > > --- a/drivers/gpu/drm/i915/intel_guc.c > > +++ b/drivers/gpu/drm/i915/intel_guc.c > > @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc) > > params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc); > > params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc); > > > > + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++) > > + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]); > > + > > Reviewed-by: Michał Winiarski <michal.winiarski@intel.com> And pushed. Thanks for the patch and review, -Chris
diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c index 1aff30b..feecf6e5 100644 --- a/drivers/gpu/drm/i915/intel_guc.c +++ b/drivers/gpu/drm/i915/intel_guc.c @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc) params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc); params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc); + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++) + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]); + /* * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and * they are power context saved so it's ok to release forcewake