Message ID | 20180703193515.4379-1-mamlinav@gmail.com (mailing list archive) |
---|---|
State | Rejected |
Headers | show |
On Tue, Jul 03, 2018 at 10:35:15PM +0300, Aleksei Mamlin wrote: > This patch replaces deprecated call to hwmon_device_register() with the new > hwmon_device_register_with_info(). > > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> NACK. This doesn't really convert anything, it just exploits a loophole that was necessary because some drivers can not be converted cleanly. Guenter > --- > drivers/hwmon/w83795.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c > index 49276bbdac3d..25bcf988ef1c 100644 > --- a/drivers/hwmon/w83795.c > +++ b/drivers/hwmon/w83795.c > @@ -2234,7 +2234,8 @@ static int w83795_probe(struct i2c_client *client, > if (data->chip_type == w83795g) > w83795_check_dynamic_in_limits(client); > > - data->hwmon_dev = hwmon_device_register(dev); > + data->hwmon_dev = hwmon_device_register_with_info(dev, client->name, > + data, NULL, NULL); > if (IS_ERR(data->hwmon_dev)) { > err = PTR_ERR(data->hwmon_dev); > goto exit_remove; > -- > 2.16.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c index 49276bbdac3d..25bcf988ef1c 100644 --- a/drivers/hwmon/w83795.c +++ b/drivers/hwmon/w83795.c @@ -2234,7 +2234,8 @@ static int w83795_probe(struct i2c_client *client, if (data->chip_type == w83795g) w83795_check_dynamic_in_limits(client); - data->hwmon_dev = hwmon_device_register(dev); + data->hwmon_dev = hwmon_device_register_with_info(dev, client->name, + data, NULL, NULL); if (IS_ERR(data->hwmon_dev)) { err = PTR_ERR(data->hwmon_dev); goto exit_remove;
This patch replaces deprecated call to hwmon_device_register() with the new hwmon_device_register_with_info(). Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> --- drivers/hwmon/w83795.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)