diff mbox

usb: quirks: add delay quirks for Corsair Strafe

Message ID 20180702162607.5830-1-snecknico@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nico Sneck July 2, 2018, 4:26 p.m. UTC
Corsair Strafe appears to suffer from the same issues
as the Corsair Strafe RGB.
Apply the same quirks (control message delay and init delay)
that the RGB version has to 1b1c:1b15.

With these quirks in place the keyboard works correctly upon
booting the system, and no longer requires reattaching the device.

Signed-off-by: Nico Sneck <snecknico@gmail.com>
---
 drivers/usb/core/quirks.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Nico Sneck July 4, 2018, 12:14 p.m. UTC | #1
CC Greg in hopes of having someone take a look at this patch before
Monday (when my military service starts).

On 02.07.2018 19:26, Nico Sneck wrote:
> Corsair Strafe appears to suffer from the same issues
> as the Corsair Strafe RGB.
> Apply the same quirks (control message delay and init delay)
> that the RGB version has to 1b1c:1b15.
> 
> With these quirks in place the keyboard works correctly upon
> booting the system, and no longer requires reattaching the device.
> 
> Signed-off-by: Nico Sneck <snecknico@gmail.com>
> ---
>   drivers/usb/core/quirks.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index c55def2f1320..097057d2eacf 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -378,6 +378,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>   	/* Corsair K70 RGB */
>   	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
>   
> +	/* Corsair Strafe */
> +	{ USB_DEVICE(0x1b1c, 0x1b15), .driver_info = USB_QUIRK_DELAY_INIT |
> +	  USB_QUIRK_DELAY_CTRL_MSG },
> +
>   	/* Corsair Strafe RGB */
>   	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
>   	  USB_QUIRK_DELAY_CTRL_MSG },
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman July 4, 2018, 12:16 p.m. UTC | #2
On Wed, Jul 04, 2018 at 03:14:17PM +0300, Nico Sneck wrote:
> CC Greg in hopes of having someone take a look at this patch before
> Monday (when my military service starts).

It's in my queue, will probably get to it next week.  At first glance
looks fine.

Good luck on your service!

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index c55def2f1320..097057d2eacf 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -378,6 +378,10 @@  static const struct usb_device_id usb_quirk_list[] = {
 	/* Corsair K70 RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
 
+	/* Corsair Strafe */
+	{ USB_DEVICE(0x1b1c, 0x1b15), .driver_info = USB_QUIRK_DELAY_INIT |
+	  USB_QUIRK_DELAY_CTRL_MSG },
+
 	/* Corsair Strafe RGB */
 	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
 	  USB_QUIRK_DELAY_CTRL_MSG },