diff mbox

qmi_wwan: add support for Quectel EG91

Message ID 1530715205-13676-1-git-send-email-vucnikm@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Matevz Vucnik July 4, 2018, 2:40 p.m. UTC
This adds the USB id of LTE modem Quectel EG91. It requires the
same quirk as other Quectel modems to make it work.

Signed-off-by: Matevz Vucnik <vucnikm@gmail.com>
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjørn Mork July 4, 2018, 2:55 p.m. UTC | #1
On July 4, 2018 4:40:05 PM GMT+02:00, Matevz Vucnik <vucnikm@gmail.com> wrote:
>This adds the USB id of LTE modem Quectel EG91. It requires the
>same quirk as other Quectel modems to make it work.
>
>Signed-off-by: Matevz Vucnik <vucnikm@gmail.com>
>---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>index 8fac8e1..829c05b 100644
>--- a/drivers/net/usb/qmi_wwan.c
>+++ b/drivers/net/usb/qmi_wwan.c
>@@ -1255,6 +1255,7 @@ static const struct usb_device_id products[] = {
> 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
> 	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
> 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0306, 4)},	/* Quectel EP06 Mini PCIe */
>+	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
> 
> 	/* 4. Gobi 1000 devices */
> 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

I know it's not perfect before, but can we try to keep new entries in numerical order? 

Thanks 


Bjørn 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bjørn Mork July 4, 2018, 3:56 p.m. UTC | #2
Matevž Vučnik <vucnikm@gmail.com> writes:

> Sorry, I missed this one. It's a good idea to keep numerical order. Is it ok
> to fix it and send a new patch?

Yes, sure. Just label it as v2 or similar to make it clear that it's a
new version of the same patch.



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 8fac8e1..829c05b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1255,6 +1255,7 @@  static const struct usb_device_id products[] = {
 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)},	/* Quectel EC21 Mini PCIe */
 	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
 	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0306, 4)},	/* Quectel EP06 Mini PCIe */
+	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
 
 	/* 4. Gobi 1000 devices */
 	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */