diff mbox

[i-g-t] igt/perf: Check the GPU is not wedged before running

Message ID 20180704145100.19202-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson July 4, 2018, 2:51 p.m. UTC
If the GPU is not usable, we will not be able to submit workloads to be
measured and so observing them will fail.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Lionel Landwerlin July 4, 2018, 10:53 p.m. UTC | #1
On 04/07/18 15:51, Chris Wilson wrote:
> If the GPU is not usable, we will not be able to submit workloads to be
> measured and so observing them will fail.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

Which reminds me, some day I'll have to check what happens with 
i915/perf during a hang...

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

> ---
>   tests/perf.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/perf.c b/tests/perf.c
> index 95048bfa5..2736918f7 100644
> --- a/tests/perf.c
> +++ b/tests/perf.c
> @@ -4109,7 +4109,10 @@ igt_main
>   		 * should have closed drm_fd...
>   		 */
>   		igt_assert_eq(drm_fd, -1);
> +
>   		drm_fd = drm_open_driver(DRIVER_INTEL);
> +		igt_require_gem(drm_fd);
> +
>   		devid = intel_get_drm_devid(drm_fd);
>   		sysfs = igt_sysfs_open(drm_fd, &card);
>
diff mbox

Patch

diff --git a/tests/perf.c b/tests/perf.c
index 95048bfa5..2736918f7 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -4109,7 +4109,10 @@  igt_main
 		 * should have closed drm_fd...
 		 */
 		igt_assert_eq(drm_fd, -1);
+
 		drm_fd = drm_open_driver(DRIVER_INTEL);
+		igt_require_gem(drm_fd);
+
 		devid = intel_get_drm_devid(drm_fd);
 		sysfs = igt_sysfs_open(drm_fd, &card);