diff mbox

[v2,1/2] ARM64: meson: Add 'usb2_phy0' in P212 DT file

Message ID 20180709153407.29138-2-ldevulder@suse.de (mailing list archive)
State Not Applicable
Headers show

Commit Message

Loic Devulder July 9, 2018, 3:34 p.m. UTC
Enable power supply for USB Amlogic Meson GXL P212 based boards.

Signed-off-by: Loic Devulder <ldevulder@suse.de>
---
 arch/arm/dts/meson-gxl-s905x-p212.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Neil Armstrong July 9, 2018, 6:14 p.m. UTC | #1
Hi Loic,

On 09/07/2018 17:34, Loic Devulder wrote:
> Enable power supply for USB Amlogic Meson GXL P212 based boards.
> 
> Signed-off-by: Loic Devulder <ldevulder@suse.de>

We like to keep the u-boot and linux DTS synced, this changed was backported on Linux v4.17.5,
can you instead precise you backported the last fix from the 4.17 stable branch ?

Thanks,
Neil

> ---
>  arch/arm/dts/meson-gxl-s905x-p212.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-gxl-s905x-p212.dtsi b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
> index 0cfd701809..4e61ec8f5b 100644
> --- a/arch/arm/dts/meson-gxl-s905x-p212.dtsi
> +++ b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
> @@ -189,3 +189,11 @@
>  &usb0 {
>  	status = "okay";
>  };
> +
> +&usb2_phy0 {
> +        /*
> +         * even though the schematics don't show it:
> +         * HDMI_5V is also used as supply for the USB VBUS.
> +         */
> +        phy-supply = <&hdmi_5v>;
> +};
>
Loic Devulder July 9, 2018, 7:56 p.m. UTC | #2
Hi Neil,

Sure, I did not see you'd done the change on Linux DTS :)

On 07/09/2018 08:14 PM, Neil Armstrong wrote:
> Hi Loic,
> 
> On 09/07/2018 17:34, Loic Devulder wrote:
>> Enable power supply for USB Amlogic Meson GXL P212 based boards.
>>
>> Signed-off-by: Loic Devulder <ldevulder@suse.de>
> 
> We like to keep the u-boot and linux DTS synced, this changed was backported on Linux v4.17.5,
> can you instead precise you backported the last fix from the 4.17 stable branch ?
> 
> Thanks,
> Neil
> 
>> ---
>>  arch/arm/dts/meson-gxl-s905x-p212.dtsi | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/dts/meson-gxl-s905x-p212.dtsi b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
>> index 0cfd701809..4e61ec8f5b 100644
>> --- a/arch/arm/dts/meson-gxl-s905x-p212.dtsi
>> +++ b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
>> @@ -189,3 +189,11 @@
>>  &usb0 {
>>  	status = "okay";
>>  };
>> +
>> +&usb2_phy0 {
>> +        /*
>> +         * even though the schematics don't show it:
>> +         * HDMI_5V is also used as supply for the USB VBUS.
>> +         */
>> +        phy-supply = <&hdmi_5v>;
>> +};
>>
>
diff mbox

Patch

diff --git a/arch/arm/dts/meson-gxl-s905x-p212.dtsi b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
index 0cfd701809..4e61ec8f5b 100644
--- a/arch/arm/dts/meson-gxl-s905x-p212.dtsi
+++ b/arch/arm/dts/meson-gxl-s905x-p212.dtsi
@@ -189,3 +189,11 @@ 
 &usb0 {
 	status = "okay";
 };
+
+&usb2_phy0 {
+        /*
+         * even though the schematics don't show it:
+         * HDMI_5V is also used as supply for the USB VBUS.
+         */
+        phy-supply = <&hdmi_5v>;
+};