| Message ID | 20180709083650.23549-9-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 9 Jul 2018, Daniel Vetter wrote: > Avoids the inverted check compared to the open-coded version. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Finn Thain <fthain@telegraphics.com.au> > Cc: linux-m68k@lists.linux-m68k.org Acked-by: Finn Thain <fthain@telegraphics.com.au> > --- > include/linux/nubus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/nubus.h b/include/linux/nubus.h > index eba50b057f6f..17fd07578ef7 100644 > --- a/include/linux/nubus.h > +++ b/include/linux/nubus.h > @@ -127,7 +127,7 @@ struct nubus_rsrc *nubus_next_rsrc_or_null(struct nubus_rsrc *from); > for (f = nubus_first_rsrc_or_null(); f; f = nubus_next_rsrc_or_null(f)) > > #define for_each_board_func_rsrc(b, f) \ > - for_each_func_rsrc(f) if (f->board != b) {} else > + for_each_func_rsrc(f) for_each_if (f->board == b) > > /* These are somewhat more NuBus-specific. They all return 0 for > success and -1 for failure, as you'd expect. */ >
Hi Daniel, On Mon, Jul 9, 2018 at 10:44 AM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Avoids the inverted check compared to the open-coded version. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Finn Thain <fthain@telegraphics.com.au> > Cc: linux-m68k@lists.linux-m68k.org Thanks for your patch! > --- a/include/linux/nubus.h > +++ b/include/linux/nubus.h > @@ -127,7 +127,7 @@ struct nubus_rsrc *nubus_next_rsrc_or_null(struct nubus_rsrc *from); > for (f = nubus_first_rsrc_or_null(); f; f = nubus_next_rsrc_or_null(f)) > > #define for_each_board_func_rsrc(b, f) \ > - for_each_func_rsrc(f) if (f->board != b) {} else > + for_each_func_rsrc(f) for_each_if (f->board == b) drivers/net/ethernet/8390/mac8390.c: In function ‘mac8390_device_probe’: drivers/net/ethernet/8390/mac8390.c:402: error: implicit declaration of function ‘for_each_if’ drivers/net/ethernet/8390/mac8390.c:402: error: expected ‘;’ before ‘{’ token Apparently this depends on patch [01/12], which wasn't CCed to linux-m68k@lists.linux-m68k.org? Please don't split CCs if all patches in the a series are not independent. Thanks! Gr{oetje,eeting}s, Geert
diff --git a/include/linux/nubus.h b/include/linux/nubus.h index eba50b057f6f..17fd07578ef7 100644 --- a/include/linux/nubus.h +++ b/include/linux/nubus.h @@ -127,7 +127,7 @@ struct nubus_rsrc *nubus_next_rsrc_or_null(struct nubus_rsrc *from); for (f = nubus_first_rsrc_or_null(); f; f = nubus_next_rsrc_or_null(f)) #define for_each_board_func_rsrc(b, f) \ - for_each_func_rsrc(f) if (f->board != b) {} else + for_each_func_rsrc(f) for_each_if (f->board == b) /* These are somewhat more NuBus-specific. They all return 0 for success and -1 for failure, as you'd expect. */
Avoids the inverted check compared to the open-coded version. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Finn Thain <fthain@telegraphics.com.au> Cc: linux-m68k@lists.linux-m68k.org --- include/linux/nubus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)