| Message ID | 1531906490-1739-1-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: > Add missing GIC interrupts property for pwm nodes. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/boot/dts/exynos5.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi > index 5d2f0a0..9406108 100644 > --- a/arch/arm/boot/dts/exynos5.dtsi > +++ b/arch/arm/boot/dts/exynos5.dtsi > @@ -169,6 +169,11 @@ > pwm: pwm@12dd0000 { > compatible = "samsung,exynos4210-pwm"; > reg = <0x12DD0000 0x100>; > + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, Indentation here looks weird - spaces used after tabs but not aligned with first entry. Please indent it properly and align it. Best regards, Krzysztof > + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; > samsung,pwm-outputs = <0>, <1>, <2>, <3>; > #pwm-cells = <3>; > }; > -- > 2.7.4 >
Hi On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: >> Add missing GIC interrupts property for pwm nodes. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >> --- >> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >> index 5d2f0a0..9406108 100644 >> --- a/arch/arm/boot/dts/exynos5.dtsi >> +++ b/arch/arm/boot/dts/exynos5.dtsi >> @@ -169,6 +169,11 @@ >> pwm: pwm@12dd0000 { >> compatible = "samsung,exynos4210-pwm"; >> reg = <0x12DD0000 0x100>; >> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, > > Indentation here looks weird - spaces used after tabs but not aligned > with first entry. Please indent it properly and align it. > > Best regards, > Krzysztof I ram checkpatch before I submit this patch it shown no error. # scripts/checkpatch.pl --no-signoff -q 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch Best Regards -Anand > >> + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; >> samsung,pwm-outputs = <0>, <1>, <2>, <3>; >> #pwm-cells = <3>; >> }; >> -- >> 2.7.4 >>
On 18 July 2018 at 12:30, Anand Moon <linux.amoon@gmail.com> wrote: > Hi > > On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: >>> Add missing GIC interrupts property for pwm nodes. >>> >>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>> --- >>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >>> index 5d2f0a0..9406108 100644 >>> --- a/arch/arm/boot/dts/exynos5.dtsi >>> +++ b/arch/arm/boot/dts/exynos5.dtsi >>> @@ -169,6 +169,11 @@ >>> pwm: pwm@12dd0000 { >>> compatible = "samsung,exynos4210-pwm"; >>> reg = <0x12DD0000 0x100>; >>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, >>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, >> >> Indentation here looks weird - spaces used after tabs but not aligned >> with first entry. Please indent it properly and align it. >> >> Best regards, >> Krzysztof > > I ram checkpatch before I submit this patch it shown no error. > > # scripts/checkpatch.pl --no-signoff -q > 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch That's good, thank you. Still when I look at it in patchwork the indentation is wrong: https://patchwork.kernel.org/patch/10531753/ However it can be patchwork's fault, so are you sure that this is properly indented and aligned? BR, Krzysztof
Hi Krzysztof, On 18 July 2018 at 16:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 18 July 2018 at 12:30, Anand Moon <linux.amoon@gmail.com> wrote: >> Hi >> >> On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: >>>> Add missing GIC interrupts property for pwm nodes. >>>> >>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>>> --- >>>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >>>> index 5d2f0a0..9406108 100644 >>>> --- a/arch/arm/boot/dts/exynos5.dtsi >>>> +++ b/arch/arm/boot/dts/exynos5.dtsi >>>> @@ -169,6 +169,11 @@ >>>> pwm: pwm@12dd0000 { >>>> compatible = "samsung,exynos4210-pwm"; >>>> reg = <0x12DD0000 0x100>; >>>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, >>>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, >>> >>> Indentation here looks weird - spaces used after tabs but not aligned >>> with first entry. Please indent it properly and align it. >>> >>> Best regards, >>> Krzysztof >> >> I ram checkpatch before I submit this patch it shown no error. >> >> # scripts/checkpatch.pl --no-signoff -q >> 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch > > That's good, thank you. Still when I look at it in patchwork the > indentation is wrong: > https://patchwork.kernel.org/patch/10531753/ > However it can be patchwork's fault, so are you sure that this is > properly indented and aligned? > > BR, > Krzysztof I prefer vim and I use following plugin https://github.com/vivien/vim-linux-coding-style root@odroidxu4:/usr/src/odroidxu4-4kr-devel# wget -nv https://patchwork.kernel.org/patch/10531753/mbox/ -O pwm.patch 2018-07-18 10:48:09 URL:https://patchwork.kernel.org/patch/10531753/mbox/ [1460] -> "pwm.patch" [1] root@odroidxu4:/usr/src/odroidxu4-4kr-devel# root@odroidxu4:/usr/src/odroidxu4-4kr-devel# scripts/checkpatch.pl --no-signoff -q pwm.patch root@odroidxu4:/usr/src/odroidxu4-4kr-devel# Is their any other way to test checkpatch please let me know. Best Regards -Anand
On 18 July 2018 at 12:50, Anand Moon <linux.amoon@gmail.com> wrote: > Hi Krzysztof, > > On 18 July 2018 at 16:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: >> On 18 July 2018 at 12:30, Anand Moon <linux.amoon@gmail.com> wrote: >>> Hi >>> >>> On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>>> On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: >>>>> Add missing GIC interrupts property for pwm nodes. >>>>> >>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>>>> --- >>>>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >>>>> 1 file changed, 5 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >>>>> index 5d2f0a0..9406108 100644 >>>>> --- a/arch/arm/boot/dts/exynos5.dtsi >>>>> +++ b/arch/arm/boot/dts/exynos5.dtsi >>>>> @@ -169,6 +169,11 @@ >>>>> pwm: pwm@12dd0000 { >>>>> compatible = "samsung,exynos4210-pwm"; >>>>> reg = <0x12DD0000 0x100>; >>>>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, >>>>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, >>>> >>>> Indentation here looks weird - spaces used after tabs but not aligned >>>> with first entry. Please indent it properly and align it. >>>> >>>> Best regards, >>>> Krzysztof >>> >>> I ram checkpatch before I submit this patch it shown no error. >>> >>> # scripts/checkpatch.pl --no-signoff -q >>> 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch >> >> That's good, thank you. Still when I look at it in patchwork the >> indentation is wrong: >> https://patchwork.kernel.org/patch/10531753/ >> However it can be patchwork's fault, so are you sure that this is >> properly indented and aligned? >> >> BR, >> Krzysztof > > I prefer vim and I use following plugin > > https://github.com/vivien/vim-linux-coding-style > > root@odroidxu4:/usr/src/odroidxu4-4kr-devel# wget -nv > https://patchwork.kernel.org/patch/10531753/mbox/ -O pwm.patch > 2018-07-18 10:48:09 > URL:https://patchwork.kernel.org/patch/10531753/mbox/ [1460] -> > "pwm.patch" [1] > root@odroidxu4:/usr/src/odroidxu4-4kr-devel# > root@odroidxu4:/usr/src/odroidxu4-4kr-devel# scripts/checkpatch.pl > --no-signoff -q pwm.patch > root@odroidxu4:/usr/src/odroidxu4-4kr-devel# > > Is their any other way to test checkpatch please let me know. This is trivial thing and should be fixed after my first reply. But clearly we need to waste some more time... so I applied the patch to check whether patchwork shows it properly or not... and it is the same. Indentation is wrong. Please fix the weird alignment. You have existing examples in the DTSI file (rtc node) how to do it. Current indentation is clearly wrong - why using spaces after tab if this is not aligned properly? Best regards, Krzysztof
Hi Krzysztof On 18 July 2018 at 17:25, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 18 July 2018 at 12:50, Anand Moon <linux.amoon@gmail.com> wrote: >> Hi Krzysztof, >> >> On 18 July 2018 at 16:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> On 18 July 2018 at 12:30, Anand Moon <linux.amoon@gmail.com> wrote: >>>> Hi >>>> >>>> On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>>>> On 18 July 2018 at 11:34, Anand Moon <linux.amoon@gmail.com> wrote: >>>>>> Add missing GIC interrupts property for pwm nodes. >>>>>> >>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com> >>>>>> --- >>>>>> arch/arm/boot/dts/exynos5.dtsi | 5 +++++ >>>>>> 1 file changed, 5 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >>>>>> index 5d2f0a0..9406108 100644 >>>>>> --- a/arch/arm/boot/dts/exynos5.dtsi >>>>>> +++ b/arch/arm/boot/dts/exynos5.dtsi >>>>>> @@ -169,6 +169,11 @@ >>>>>> pwm: pwm@12dd0000 { >>>>>> compatible = "samsung,exynos4210-pwm"; >>>>>> reg = <0x12DD0000 0x100>; >>>>>> + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, >>>>>> + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, >>>>> >>>>> Indentation here looks weird - spaces used after tabs but not aligned >>>>> with first entry. Please indent it properly and align it. >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> I ram checkpatch before I submit this patch it shown no error. >>>> >>>> # scripts/checkpatch.pl --no-signoff -q >>>> 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch >>> >>> That's good, thank you. Still when I look at it in patchwork the >>> indentation is wrong: >>> https://patchwork.kernel.org/patch/10531753/ >>> However it can be patchwork's fault, so are you sure that this is >>> properly indented and aligned? >>> >>> BR, >>> Krzysztof >> >> I prefer vim and I use following plugin >> >> https://github.com/vivien/vim-linux-coding-style >> >> root@odroidxu4:/usr/src/odroidxu4-4kr-devel# wget -nv >> https://patchwork.kernel.org/patch/10531753/mbox/ -O pwm.patch >> 2018-07-18 10:48:09 >> URL:https://patchwork.kernel.org/patch/10531753/mbox/ [1460] -> >> "pwm.patch" [1] >> root@odroidxu4:/usr/src/odroidxu4-4kr-devel# >> root@odroidxu4:/usr/src/odroidxu4-4kr-devel# scripts/checkpatch.pl >> --no-signoff -q pwm.patch >> root@odroidxu4:/usr/src/odroidxu4-4kr-devel# >> >> Is their any other way to test checkpatch please let me know. > > This is trivial thing and should be fixed after my first reply. But > clearly we need to waste some more time... so I applied the patch to > check whether patchwork shows it properly or not... and it is the > same. Indentation is wrong. > > Please fix the weird alignment. You have existing examples in the DTSI > file (rtc node) how to do it. Current indentation is clearly wrong - > why using spaces after tab if this is not aligned properly? > > Best regards, > Krzysztof Opps sorry I have send v2 patch https://patchwork.kernel.org/patch/10532443/ with proper fix. I will do strict check next time before sending the patch. Best Regards -Anand
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index 5d2f0a0..9406108 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi @@ -169,6 +169,11 @@ pwm: pwm@12dd0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x12DD0000 0x100>; + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; samsung,pwm-outputs = <0>, <1>, <2>, <3>; #pwm-cells = <3>; };
Add missing GIC interrupts property for pwm nodes. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5.dtsi | 5 +++++ 1 file changed, 5 insertions(+)