diff mbox series

[i-g-t,1/4] lib: Don't assert all KMS drivers support edid_override

Message ID 20180723200736.29508-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [i-g-t,1/4] lib: Don't assert all KMS drivers support edid_override | expand

Commit Message

Chris Wilson July 23, 2018, 8:07 p.m. UTC
edid_override is a i915.ko debugfs feature; just skip any kms test that
depends on being able to override the edid.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107337
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/igt_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Katarzyna Dec July 24, 2018, 10:39 a.m. UTC | #1
On Mon, Jul 23, 2018 at 09:07:33PM +0100, Chris Wilson wrote:
> edid_override is a i915.ko debugfs feature; just skip any kms test that
> depends on being able to override the edid.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107337
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>

> ---
>  lib/igt_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 476a78623..c9e00c3bd 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -913,7 +913,7 @@ void kmstest_force_edid(int drm_fd, drmModeConnector *connector,
>  	debugfs_fd = igt_debugfs_open(drm_fd, path, O_WRONLY | O_TRUNC);
>  	free(path);
>  
> -	igt_assert(debugfs_fd != -1);
> +	igt_require(debugfs_fd != -1);
>  
>  	if (length == 0)
>  		ret = write(debugfs_fd, "reset", 5);
> -- 
> 2.18.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 476a78623..c9e00c3bd 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -913,7 +913,7 @@  void kmstest_force_edid(int drm_fd, drmModeConnector *connector,
 	debugfs_fd = igt_debugfs_open(drm_fd, path, O_WRONLY | O_TRUNC);
 	free(path);
 
-	igt_assert(debugfs_fd != -1);
+	igt_require(debugfs_fd != -1);
 
 	if (length == 0)
 		ret = write(debugfs_fd, "reset", 5);