| Message ID | CAPotdmQtXmfHJfcgrXZ02NrPgS3Az=SpZnBsRZ_8dGvPfdi+Mw@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi John, On Sat, 2018-07-14 at 18:06 -0700, John S Gruber wrote: > The Redragon keyboard uses the second device being presented, but > other > devices with the same vendor_id/device_id pair (0x0c45:760b) use the > first. > Don't cause its deletion. Problem introduced in commit 85455dd906d5 > ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard") This should already be fixed by dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e [1], can you please confirm? If that is the case, we should probably include that commit for 4.18 as well. Thanks, Robert [1]: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/?h=for-next&id=dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 16, 2018 at 4:51 AM Robert Munteanu <rombert@apache.org> wrote: > > Hi John, > > On Sat, 2018-07-14 at 18:06 -0700, John S Gruber wrote: > > The Redragon keyboard uses the second device being presented, but > > other > > devices with the same vendor_id/device_id pair (0x0c45:760b) use the > > first. > > Don't cause its deletion. Problem introduced in commit 85455dd906d5 > > ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard") > > > This should already be fixed by > dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e [1], can you please confirm? I applied it to the tip of linux-input repo (Jiri's) and to 4.18-rc5 in Linus' repo. In both cases the keyboard went from not working at all to working fine. > > If that is the case, we should probably include that commit for 4.18 as > well. That would work for me. > > Thanks, > > Robert > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git/commit/?h=for-next&id=dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2018-07-17 at 00:32 -0400, John S Gruber wrote: > On Mon, Jul 16, 2018 at 4:51 AM Robert Munteanu <rombert@apache.org> > wrote: > > > > Hi John, > > > > On Sat, 2018-07-14 at 18:06 -0700, John S Gruber wrote: > > > The Redragon keyboard uses the second device being presented, but > > > other > > > devices with the same vendor_id/device_id pair (0x0c45:760b) use > > > the > > > first. > > > Don't cause its deletion. Problem introduced in commit > > > 85455dd906d5 > > > ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard") > > > > > > This should already be fixed by > > dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e [1], can you please > > confirm? > > I applied it to the tip of linux-input repo (Jiri's) and to 4.18-rc5 > in Linus' repo. > > In both cases the keyboard went from not working at all to working > fine. > > > > > If that is the case, we should probably include that commit for > > 4.18 as > > well. > > That would work for me. Jiri, do you agree? If you do, should I resubmit the patch or is this email thread enough? Thanks, Robert -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2018-07-17 at 14:22 +0200, Robert Munteanu wrote: > On Tue, 2018-07-17 at 00:32 -0400, John S Gruber wrote: > > On Mon, Jul 16, 2018 at 4:51 AM Robert Munteanu <rombert@apache.org > > > > > wrote: > > > > > > Hi John, > > > > > > On Sat, 2018-07-14 at 18:06 -0700, John S Gruber wrote: > > > > The Redragon keyboard uses the second device being presented, > > > > but > > > > other > > > > devices with the same vendor_id/device_id pair (0x0c45:760b) > > > > use > > > > the > > > > first. > > > > Don't cause its deletion. Problem introduced in commit > > > > 85455dd906d5 > > > > ("HID: redragon: Fix modifier keys for Redragon Asura > > > > Keyboard") > > > > > > > > > This should already be fixed by > > > dc9b8e85ed95cbe7e3ad0eabb5b48d617bbc365e [1], can you please > > > confirm? > > > > I applied it to the tip of linux-input repo (Jiri's) and to 4.18- > > rc5 > > in Linus' repo. > > > > In both cases the keyboard went from not working at all to working > > fine. > > > > > > > > If that is the case, we should probably include that commit for > > > 4.18 as > > > well. > > > > That would work for me. > > Jiri, do you agree? If you do, should I resubmit the patch or is this > email thread enough? Ping? Should I resubmit the patch with the updated findings from John? Robert -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-redragon.c b/drivers/hid/hid-redragon.c index daf5957..85a5fbb 100644 --- a/drivers/hid/hid-redragon.c +++ b/drivers/hid/hid-redragon.c @@ -55,10 +55,6 @@ static int redragon_probe(struct hid_device *dev, return ret; } - /* do not register unused input device */ - if (dev->maxapplication == 1) - return 0; - ret = hid_hw_start(dev, HID_CONNECT_DEFAULT); if (ret) { hid_err(dev, "hw start failed\n");
The Redragon keyboard uses the second device being presented, but other devices with the same vendor_id/device_id pair (0x0c45:760b) use the first. Don't cause its deletion. Problem introduced in commit 85455dd906d5 ("HID: redragon: Fix modifier keys for Redragon Asura Keyboard") Fixes: 85455dd906d5 Signed-off-by: John S Gruber <JohnSGruber@gmail.com> --- drivers/hid/hid-redragon.c | 4 ---- 1 file changed, 4 deletions(-)