diff mbox series

platform/x86: touchscreen_dmi: Add info for the Cube KNote i1101 tablet

Message ID 20180731093256.30533-1-youling257@gmail.com (mailing list archive)
State New, archived
Headers show
Series platform/x86: touchscreen_dmi: Add info for the Cube KNote i1101 tablet | expand

Commit Message

youling 257 July 31, 2018, 9:32 a.m. UTC 
Add touchscreen info for the Cube KNote i1101 tablet.

Reported-and-tested-by: lkongl <lkongl@163.com>
---
 drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Andy Shevchenko July 31, 2018, 11:32 a.m. UTC | #1 
On Tue, Jul 31, 2018 at 12:32 PM, youling257 <youling257@gmail.com> wrote:
> Add touchscreen info for the Cube KNote i1101 tablet.
>

Thanks for the patch.
Unfortunately I can't take it w/o SoB line. If Hans volunteering to
give a such again, I guess we're fine.

> Reported-and-tested-by: lkongl <lkongl@163.com>
> ---
>  drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 85e425420da2..cb204f973491 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -117,6 +117,22 @@ static const struct ts_dmi_data cube_iwork8_air_data = {
>         .properties     = cube_iwork8_air_props,
>  };
>
> +static const struct property_entry cube_knote_i1101_props[] = {
> +       PROPERTY_ENTRY_U32("touchscreen-min-x", 20),
> +       PROPERTY_ENTRY_U32("touchscreen-min-y",  22),
> +       PROPERTY_ENTRY_U32("touchscreen-size-x", 1961),
> +       PROPERTY_ENTRY_U32("touchscreen-size-y", 1513),
> +       PROPERTY_ENTRY_STRING("firmware-name", "gsl3692-cube-knote-i1101.fw"),
> +       PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> +       PROPERTY_ENTRY_BOOL("silead,home-button"),
> +       { }
> +};
> +
> +static const struct ts_dmi_data cube_knote_i1101_data = {
> +       .acpi_name      = "MSSL1680:00",
> +       .properties     = cube_knote_i1101_props,
> +};
> +
>  static const struct property_entry dexp_ursus_7w_props[] = {
>         PROPERTY_ENTRY_U32("touchscreen-size-x", 890),
>         PROPERTY_ENTRY_U32("touchscreen-size-y", 630),
> @@ -458,6 +474,16 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
>                 },
>         },
> +       {
> +               /* Cube KNote i1101 */
> +               .driver_data = (void *)&cube_knote_i1101_data,
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> +                       DMI_MATCH(DMI_BOARD_NAME, "L1W6_I1101"),
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ALLDOCUBE"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "i1101"),
> +               },
> +       },
>         {
>                 /* DEXP Ursus 7W */
>                 .driver_data = (void *)&dexp_ursus_7w_data,
> --
> 2.18.0
>
Hans de Goede July 31, 2018, 11:53 a.m. UTC | #2 
Hi,

On 31-07-18 13:32, Andy Shevchenko wrote:
> On Tue, Jul 31, 2018 at 12:32 PM, youling257 <youling257@gmail.com> wrote:
>> Add touchscreen info for the Cube KNote i1101 tablet.
>>
> 
> Thanks for the patch.
> Unfortunately I can't take it w/o SoB line. If Hans volunteering to
> give a such again, I guess we're fine.

Yes you can add my:

Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Like last time, or do you want me to resend this with it added?

Regards,

Hans


> 
>> Reported-and-tested-by: lkongl <lkongl@163.com>
>> ---
>>   drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
>> index 85e425420da2..cb204f973491 100644
>> --- a/drivers/platform/x86/touchscreen_dmi.c
>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>> @@ -117,6 +117,22 @@ static const struct ts_dmi_data cube_iwork8_air_data = {
>>          .properties     = cube_iwork8_air_props,
>>   };
>>
>> +static const struct property_entry cube_knote_i1101_props[] = {
>> +       PROPERTY_ENTRY_U32("touchscreen-min-x", 20),
>> +       PROPERTY_ENTRY_U32("touchscreen-min-y",  22),
>> +       PROPERTY_ENTRY_U32("touchscreen-size-x", 1961),
>> +       PROPERTY_ENTRY_U32("touchscreen-size-y", 1513),
>> +       PROPERTY_ENTRY_STRING("firmware-name", "gsl3692-cube-knote-i1101.fw"),
>> +       PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>> +       PROPERTY_ENTRY_BOOL("silead,home-button"),
>> +       { }
>> +};
>> +
>> +static const struct ts_dmi_data cube_knote_i1101_data = {
>> +       .acpi_name      = "MSSL1680:00",
>> +       .properties     = cube_knote_i1101_props,
>> +};
>> +
>>   static const struct property_entry dexp_ursus_7w_props[] = {
>>          PROPERTY_ENTRY_U32("touchscreen-size-x", 890),
>>          PROPERTY_ENTRY_U32("touchscreen-size-y", 630),
>> @@ -458,6 +474,16 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
>>                          DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
>>                  },
>>          },
>> +       {
>> +               /* Cube KNote i1101 */
>> +               .driver_data = (void *)&cube_knote_i1101_data,
>> +               .matches = {
>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
>> +                       DMI_MATCH(DMI_BOARD_NAME, "L1W6_I1101"),
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "ALLDOCUBE"),
>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "i1101"),
>> +               },
>> +       },
>>          {
>>                  /* DEXP Ursus 7W */
>>                  .driver_data = (void *)&dexp_ursus_7w_data,
>> --
>> 2.18.0
>>
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andy Shevchenko July 31, 2018, 3:10 p.m. UTC | #3 
On Tue, Jul 31, 2018 at 2:53 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 31-07-18 13:32, Andy Shevchenko wrote:
>>
>> On Tue, Jul 31, 2018 at 12:32 PM, youling257 <youling257@gmail.com> wrote:
>>>
>>> Add touchscreen info for the Cube KNote i1101 tablet.
>>>
>>
>> Thanks for the patch.
>> Unfortunately I can't take it w/o SoB line. If Hans volunteering to
>> give a such again, I guess we're fine.
>
>
> Yes you can add my:
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Like last time, or do you want me to resend this with it added?

I'll use it as Author, no need to resubmit, thanks!

>
> Regards,
>
> Hans
>
>
>
>>
>>> Reported-and-tested-by: lkongl <lkongl@163.com>
>>> ---
>>>   drivers/platform/x86/touchscreen_dmi.c | 26 ++++++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/touchscreen_dmi.c
>>> b/drivers/platform/x86/touchscreen_dmi.c
>>> index 85e425420da2..cb204f973491 100644
>>> --- a/drivers/platform/x86/touchscreen_dmi.c
>>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>>> @@ -117,6 +117,22 @@ static const struct ts_dmi_data cube_iwork8_air_data
>>> = {
>>>          .properties     = cube_iwork8_air_props,
>>>   };
>>>
>>> +static const struct property_entry cube_knote_i1101_props[] = {
>>> +       PROPERTY_ENTRY_U32("touchscreen-min-x", 20),
>>> +       PROPERTY_ENTRY_U32("touchscreen-min-y",  22),
>>> +       PROPERTY_ENTRY_U32("touchscreen-size-x", 1961),
>>> +       PROPERTY_ENTRY_U32("touchscreen-size-y", 1513),
>>> +       PROPERTY_ENTRY_STRING("firmware-name",
>>> "gsl3692-cube-knote-i1101.fw"),
>>> +       PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>>> +       PROPERTY_ENTRY_BOOL("silead,home-button"),
>>> +       { }
>>> +};
>>> +
>>> +static const struct ts_dmi_data cube_knote_i1101_data = {
>>> +       .acpi_name      = "MSSL1680:00",
>>> +       .properties     = cube_knote_i1101_props,
>>> +};
>>> +
>>>   static const struct property_entry dexp_ursus_7w_props[] = {
>>>          PROPERTY_ENTRY_U32("touchscreen-size-x", 890),
>>>          PROPERTY_ENTRY_U32("touchscreen-size-y", 630),
>>> @@ -458,6 +474,16 @@ static const struct dmi_system_id
>>> touchscreen_dmi_table[] = {
>>>                          DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
>>>                  },
>>>          },
>>> +       {
>>> +               /* Cube KNote i1101 */
>>> +               .driver_data = (void *)&cube_knote_i1101_data,
>>> +               .matches = {
>>> +                       DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
>>> +                       DMI_MATCH(DMI_BOARD_NAME, "L1W6_I1101"),
>>> +                       DMI_MATCH(DMI_SYS_VENDOR, "ALLDOCUBE"),
>>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "i1101"),
>>> +               },
>>> +       },
>>>          {
>>>                  /* DEXP Ursus 7W */
>>>                  .driver_data = (void *)&dexp_ursus_7w_data,
>>> --
>>> 2.18.0
>>>
>>
>>
>>
>
diff mbox series

Patch

diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 85e425420da2..cb204f973491 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -117,6 +117,22 @@  static const struct ts_dmi_data cube_iwork8_air_data = {
 	.properties	= cube_iwork8_air_props,
 };
 
+static const struct property_entry cube_knote_i1101_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-min-x", 20),
+	PROPERTY_ENTRY_U32("touchscreen-min-y",  22),
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1961),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1513),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl3692-cube-knote-i1101.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data cube_knote_i1101_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= cube_knote_i1101_props,
+};
+
 static const struct property_entry dexp_ursus_7w_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-size-x", 890),
 	PROPERTY_ENTRY_U32("touchscreen-size-y", 630),
@@ -458,6 +474,16 @@  static const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
 		},
 	},
+	{
+		/* Cube KNote i1101 */
+		.driver_data = (void *)&cube_knote_i1101_data,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+			DMI_MATCH(DMI_BOARD_NAME, "L1W6_I1101"),
+			DMI_MATCH(DMI_SYS_VENDOR, "ALLDOCUBE"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "i1101"),
+		},
+	},
 	{
 		/* DEXP Ursus 7W */
 		.driver_data = (void *)&dexp_ursus_7w_data,