[v4,0/2] s390x: Enable KVM huge page backing support

Message

Janosch Frank Aug. 1, 2018, 1:19 p.m. UTC

v4:
	* Now using MiB
	* Now supporting 4k memory backings

v3:
	* Fixed Cap name
	* Added mempath page size check and error reporting

Janosch Frank (2):
  kvm: sync linux headers
  s390x: Enable KVM huge page backing support

 linux-headers/linux/kvm.h |  1 +
 target/s390x/kvm.c        | 34 ++++++++++++++++++++++++++++++++--
 2 files changed, 33 insertions(+), 2 deletions(-)

Comments

Cornelia Huck Aug. 1, 2018, 4:01 p.m. UTC | #1

On Wed,  1 Aug 2018 14:19:03 +0100
Janosch Frank <[e-mail]> wrote:

> v4:
> 	* Now using MiB
> 	* Now supporting 4k memory backings
> 
> v3:
> 	* Fixed Cap name
> 	* Added mempath page size check and error reporting
> 
> Janosch Frank (2):
>   kvm: sync linux headers
>   s390x: Enable KVM huge page backing support
> 
>  linux-headers/linux/kvm.h |  1 +
>  target/s390x/kvm.c        | 34 ++++++++++++++++++++++++++++++++--
>  2 files changed, 33 insertions(+), 2 deletions(-)
> 

Looks good to me.

Same comment as for the etoken patch: I'll queue this as soon as the
kernel interface has landed (and we can do a proper headers update).
Please ping me if I forget about it :)

[e-mail] Aug. 1, 2018, 6:49 p.m. UTC | #2

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4290dbe857 s390x: Enable KVM huge page backing support
adfd7a6890 kvm: sync linux headers

=== OUTPUT BEGIN ===
Checking PATCH 1/2: kvm: sync linux headers...
Checking PATCH 2/2: s390x: Enable KVM huge page backing support...
ERROR: braces {} are necessary for all arms of this statement
#59: FILE: target/s390x/kvm.c:291:
+    if (path_psize == 4 * KiB)
[...]

total: 1 errors, 0 warnings, 63 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [e-mail]

Cornelia Huck Aug. 20, 2018, 9:03 a.m. UTC | #3

On Wed, 1 Aug 2018 18:01:59 +0200
Cornelia Huck <[e-mail]> wrote:

> On Wed,  1 Aug 2018 14:19:03 +0100
> Janosch Frank <[e-mail]> wrote:
> 
> > v4:
> > 	* Now using MiB
> > 	* Now supporting 4k memory backings
> > 
> > v3:
> > 	* Fixed Cap name
> > 	* Added mempath page size check and error reporting
> > 
> > Janosch Frank (2):
> >   kvm: sync linux headers
> >   s390x: Enable KVM huge page backing support
> > 
> >  linux-headers/linux/kvm.h |  1 +
> >  target/s390x/kvm.c        | 34 ++++++++++++++++++++++++++++++++--
> >  2 files changed, 33 insertions(+), 2 deletions(-)
> >   
> 
> Looks good to me.
> 
> Same comment as for the etoken patch: I'll queue this as soon as the
> kernel interface has landed (and we can do a proper headers update).
> Please ping me if I forget about it :)

Same comment as for the etoken patch, again :) Just pushed out to
s390-next.

Thanks, applied.