mbox series

[0/5] pinctrl: meson: Add support for TEST_N gpio

Message ID 1533117623-27856-1-git-send-email-narmstrong@baylibre.com (mailing list archive)
Headers show
Series pinctrl: meson: Add support for TEST_N gpio | expand

Message

Neil Armstrong Aug. 1, 2018, 10 a.m. UTC 
The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to
set the TEST_N pin direction.
This patchset :
- adds the Secure Monitor call
- adds support int the pinctrl-meson common code
- adds support for GXBB, GXL and AGX SoCs

Neil Armstrong (5):
  meson_sm: add TEST_N pin direction call
  pinctrl: meson: Add support to set direction with a secure monitor
    call
  meson: pinctrl-gxbb: add support for TEST_N pin
  meson: pinctrl-gxl: add support for TEST_N pin
  meson: pinctrl-axg: add support for TEST_N pin

 drivers/firmware/meson/meson_sm.c          |  1 +
 drivers/pinctrl/meson/Kconfig              |  1 +
 drivers/pinctrl/meson/pinctrl-meson-axg.c  |  4 ++++
 drivers/pinctrl/meson/pinctrl-meson-gxbb.c |  4 ++++
 drivers/pinctrl/meson/pinctrl-meson-gxl.c  |  4 ++++
 drivers/pinctrl/meson/pinctrl-meson.c      | 31 +++++++++++++++++++++++++-----
 drivers/pinctrl/meson/pinctrl-meson.h      | 10 +++++++++-
 include/linux/firmware/meson/meson_sm.h    |  1 +
 8 files changed, 50 insertions(+), 6 deletions(-)

Comments

Linus Walleij Aug. 3, 2018, 5:10 p.m. UTC | #1 
On Wed, Aug 1, 2018 at 12:00 PM Neil Armstrong <narmstrong@baylibre.com> wrote:

> The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to
> set the TEST_N pin direction.
> This patchset :
> - adds the Secure Monitor call
> - adds support int the pinctrl-meson common code
> - adds support for GXBB, GXL and AGX SoCs

A lot of trouble to access a single GPIO pin (I guess _N means "active low"?)

Is this line used for something especially important? Would be nice to
include in some commit message like patch 1/5 why we invest so much
energy to accessing this pin.

Just curious. If you're just aiming for feature completion, that is a good
reason as well :D

Yours,
Linus Walleij