| Message ID | 20180804161530.12275-10-alexandru-cosmin.gheorghe@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add helper for plane reset | expand |
Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> writes: > A new helper function(__drm_atomic_helper_plane_reset) has been added > for linking a plane with its state and resetting the core > properties(alpha, rotation, etc.) to their default values. > Use that instead of duplicating the logic. > > __drm_atomic_helper_plane_reset initializes the alpha property to its > max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, > so nothing changes regarding the alpha value. > > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> Acked-by: Eric Anholt <eric@anholt.net>
Hi Eric, On Mon, Aug 06, 2018 at 12:58:20PM -0700, Eric Anholt wrote: > Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> writes: > > > A new helper function(__drm_atomic_helper_plane_reset) has been added > > for linking a plane with its state and resetting the core > > properties(alpha, rotation, etc.) to their default values. > > Use that instead of duplicating the logic. > > > > __drm_atomic_helper_plane_reset initializes the alpha property to its > > max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, > > so nothing changes regarding the alpha value. > > > > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> > > Acked-by: Eric Anholt <eric@anholt.net> Pushed to drmi-misc-next. -- Cheers, Alex G IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 9d7a36f148cf..688ad9bb0f08 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c @@ -200,9 +200,7 @@ static void vc4_plane_reset(struct drm_plane *plane) if (!vc4_state) return; - plane->state = &vc4_state->base; - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - vc4_state->base.plane = plane; + __drm_atomic_helper_plane_reset(plane, &vc4_state->base); } static void vc4_dlist_write(struct vc4_plane_state *vc4_state, u32 val)
A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> --- drivers/gpu/drm/vc4/vc4_plane.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)