| Message ID | 20180807130234.5380-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [net-next] ceph: remove unnecessary non NULL check for request_key | expand |
On Tue, Aug 7, 2018 at 3:03 PM YueHaibing <yuehaibing@huawei.com> wrote: > > request_key never return NULL,so no need do non-NULL check. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > net/ceph/ceph_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c > index 584fdbe..9834edc 100644 > --- a/net/ceph/ceph_common.c > +++ b/net/ceph/ceph_common.c > @@ -304,7 +304,7 @@ static int get_secret(struct ceph_crypto_key *dst, const char *name) { > struct ceph_crypto_key *ckey; > > ukey = request_key(&key_type_ceph, name, NULL); > - if (!ukey || IS_ERR(ukey)) { > + if (IS_ERR(ukey)) { > /* request_key errors don't map nicely to mount(2) > errors; don't even try, but still printk */ > key_err = PTR_ERR(ukey); Applied. Thanks, Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c index 584fdbe..9834edc 100644 --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c @@ -304,7 +304,7 @@ static int get_secret(struct ceph_crypto_key *dst, const char *name) { struct ceph_crypto_key *ckey; ukey = request_key(&key_type_ceph, name, NULL); - if (!ukey || IS_ERR(ukey)) { + if (IS_ERR(ukey)) { /* request_key errors don't map nicely to mount(2) errors; don't even try, but still printk */ key_err = PTR_ERR(ukey);
request_key never return NULL,so no need do non-NULL check. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/ceph/ceph_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)