| Message ID | 0aaacf083be5b68a830f9e174f9abee3b00c5a51.1530402641.git.joeypabalinas@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas <joeypabalinas@gmail.com> wrote: > The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial > protocol, so avoid setting `td->serial_maybe = true;` in order to avoid > an unnecessary mt_post_parse_default_settings() call > > Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> > > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index a793076139d7d0db9b..c0654db0b736543ca0 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -1460,11 +1460,13 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) > if (!td->fields) { > dev_err(&hdev->dev, "cannot allocate multitouch fields data\n"); > return -ENOMEM; > } > > - if (id->vendor == HID_ANY_ID && id->product == HID_ANY_ID) > + if (id->vendor == HID_ANY_ID > + && id->product == HID_ANY_ID > + && id->group != HID_GROUP_MULTITOUCH_WIN_8) There is a tiny difference between the HID group (this device looks like it is used as a Win 8 device) and the device class (this is effectively a Win8 device) It makes sense to remove this check for Win8 devices, but I don't think it should be done for all devices. All in all, it won't change much. Cheers, Benjamin > td->serial_maybe = true; > > /* This allows the driver to correctly support devices > * that emit events over several HID messages. > */ > -- > 2.18.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 03, 2018 at 10:16:01AM +0200, Benjamin Tissoires wrote: > There is a tiny difference between the HID group (this device looks > like it is used as a Win 8 device) and the device class (this is > effectively a Win8 device) > > It makes sense to remove this check for Win8 devices, but I don't > think it should be done for all devices. > > All in all, it won't change much. Hm, that sounds sane. I'll do a bit more research on this and see if restricting it to just Win8 devices is simple enough to be worthwhile.
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index a793076139d7d0db9b..c0654db0b736543ca0 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -1460,11 +1460,13 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id) if (!td->fields) { dev_err(&hdev->dev, "cannot allocate multitouch fields data\n"); return -ENOMEM; } - if (id->vendor == HID_ANY_ID && id->product == HID_ANY_ID) + if (id->vendor == HID_ANY_ID + && id->product == HID_ANY_ID + && id->group != HID_GROUP_MULTITOUCH_WIN_8) td->serial_maybe = true; /* This allows the driver to correctly support devices * that emit events over several HID messages. */
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> 1 file changed, 3 insertions(+), 1 deletion(-)