| Message ID | 20180615223749.149073-1-ndesaulniers@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
bumping for review. On Fri, Jun 15, 2018 at 3:38 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Fixes commit 8cfe83419cdb ("drm/panel: simple: Add > support for KEO TX31D200VM0BAA") > > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > [-Wliteral-conversion] > .vfront_porch = { 6, 21, 33.5 }, > ~ ^~~~ > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > [-Wliteral-conversion] > .vback_porch = { 6, 21, 33.5 }, > ~ ^~~~ > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Alternatively, should these be rounded up to 34? I'm guessing the > current behaviour (truncation) is correct since that's how the patch was > operating. > > drivers/gpu/drm/panel/panel-simple.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index cbf1ab404ee7..12bcbd1dd77b 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = { > .hback_porch = { 16, 36, 56 }, > .hsync_len = { 8, 8, 8 }, > .vactive = { 480, 480, 480 }, > - .vfront_porch = { 6, 21, 33.5 }, > - .vback_porch = { 6, 21, 33.5 }, > + .vfront_porch = { 6, 21, 33 }, > + .vback_porch = { 6, 21, 33 }, > .vsync_len = { 8, 8, 8 }, > .flags = DISPLAY_FLAGS_DE_HIGH, > }; > -- > 2.18.0.rc1.244.gcf134e6275-goog >
On Fri, Jun 15, 2018 at 03:37:49PM -0700, Nick Desaulniers wrote: > Fixes commit 8cfe83419cdb ("drm/panel: simple: Add > support for KEO TX31D200VM0BAA") > > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > [-Wliteral-conversion] > .vfront_porch = { 6, 21, 33.5 }, > ~ ^~~~ > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > [-Wliteral-conversion] > .vback_porch = { 6, 21, 33.5 }, > ~ ^~~~ > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Alternatively, should these be rounded up to 34? I'm guessing the > current behaviour (truncation) is correct since that's how the patch was > operating. Looks like this is a duplicate of what was merged as: commit c9b6be7dc13e2f87592ee4c9812cb450dba484d5 Author: Stefan Agner <stefan@agner.ch> Date: Thu Apr 19 23:20:03 2018 +0200 drm/panel: simple: Fix data type in KEO TX31D200VM0BAA timings All values in a struct struct timing_entry (every entry in struct display_timing) require an integer. Choose the closest safe integer of 32. This avoids a warning seen with clang: drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vfront_porch = { 6, 21, 33.5 }, ~ ^~~~ drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vback_porch = { 6, 21, 33.5 }, ~ ^~~~ Signed-off-by: Stefan Agner <stefan@agner.ch> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180419212003.8155-1-stefan@agner.ch Thierry
On Thu, Aug 9, 2018 at 3:00 AM Thierry Reding <thierry.reding@gmail.com> wrote: > > On Fri, Jun 15, 2018 at 03:37:49PM -0700, Nick Desaulniers wrote: > > Fixes commit 8cfe83419cdb ("drm/panel: simple: Add > > support for KEO TX31D200VM0BAA") > > > > drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from > > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > > [-Wliteral-conversion] > > .vfront_porch = { 6, 21, 33.5 }, > > ~ ^~~~ > > drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from > > 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 > > [-Wliteral-conversion] > > .vback_porch = { 6, 21, 33.5 }, > > ~ ^~~~ > > > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > --- > > Alternatively, should these be rounded up to 34? I'm guessing the > > current behaviour (truncation) is correct since that's how the patch was > > operating. > > Looks like this is a duplicate of what was merged as: > > commit c9b6be7dc13e2f87592ee4c9812cb450dba484d5 > Author: Stefan Agner <stefan@agner.ch> > Date: Thu Apr 19 23:20:03 2018 +0200 Ah, cool. I need to be better about checking maintainers' trees. Just curious, how come a patch from April hasn't hit torvalds/linux yet?
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index cbf1ab404ee7..12bcbd1dd77b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1247,8 +1247,8 @@ static const struct display_timing koe_tx31d200vm0baa_timing = { .hback_porch = { 16, 36, 56 }, .hsync_len = { 8, 8, 8 }, .vactive = { 480, 480, 480 }, - .vfront_porch = { 6, 21, 33.5 }, - .vback_porch = { 6, 21, 33.5 }, + .vfront_porch = { 6, 21, 33 }, + .vback_porch = { 6, 21, 33 }, .vsync_len = { 8, 8, 8 }, .flags = DISPLAY_FLAGS_DE_HIGH, };
Fixes commit 8cfe83419cdb ("drm/panel: simple: Add support for KEO TX31D200VM0BAA") drivers/gpu/drm/panel/panel-simple.c:1250:27: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vfront_porch = { 6, 21, 33.5 }, ~ ^~~~ drivers/gpu/drm/panel/panel-simple.c:1251:26: warning: implicit conversion from 'double' to 'u32' (aka 'unsigned int') changes value from 33.5 to 33 [-Wliteral-conversion] .vback_porch = { 6, 21, 33.5 }, ~ ^~~~ Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- Alternatively, should these be rounded up to 34? I'm guessing the current behaviour (truncation) is correct since that's how the patch was operating. drivers/gpu/drm/panel/panel-simple.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)