| Message ID | 20180815095934.11205-3-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy: rockchip-inno-usb2: document improvements and allow to force B-device valid session bit. | expand |
Hi Enric, Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: > Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for > rk3399") introduces two new properties. The extcon property is used to > detect the cable-state, and the rockchip,utmi-avalid is used to indicate > which register should be used to detect the vbus state. > > Document these properties in the documentation binding. > > Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > index 074a7b3b0425..2d4808d3920b 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > @@ -23,6 +23,7 @@ Optional properties: > register files". When set driver will request its > phandle as one companion-grf for some special SoCs > (e.g RV1108). > + - extcon : phandle to the extcon device for the otg phy. That should probably mention that this is the extcon providing the cable-state? > Required nodes : a sub-node is required for each port the phy provides. > The sub-node name is used to identify host or otg port, > @@ -45,6 +46,8 @@ Required properties (port (child) node): > Optional properties: > - phy-supply : phandle to a regulator that provides power to VBUS. > See ./phy-bindings.txt for details. > + - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. > + Otherwise, use the bvalid register. Not having looked to deeply into the usb2 phy, this might raise questions on why this is a hardware-description? Is this needed when something is not connected on the board? Heiko
Hi Heiko, On 15/08/18 12:29, Heiko Stuebner wrote: > Hi Enric, > > Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properties. The extcon property is used to >> detect the cable-state, and the rockchip,utmi-avalid is used to indicate >> which register should be used to detect the vbus state. >> >> Document these properties in the documentation binding. >> >> Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> --- >> >> .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> index 074a7b3b0425..2d4808d3920b 100644 >> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> @@ -23,6 +23,7 @@ Optional properties: >> register files". When set driver will request its >> phandle as one companion-grf for some special SoCs >> (e.g RV1108). >> + - extcon : phandle to the extcon device for the otg phy. > > That should probably mention that this is the extcon providing the cable-state? ack. > > >> Required nodes : a sub-node is required for each port the phy provides. >> The sub-node name is used to identify host or otg port, >> @@ -45,6 +46,8 @@ Required properties (port (child) node): >> Optional properties: >> - phy-supply : phandle to a regulator that provides power to VBUS. >> See ./phy-bindings.txt for details. >> + - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. >> + Otherwise, use the bvalid register. > > Not having looked to deeply into the usb2 phy, this might raise questions > on why this is a hardware-description? Is this needed when something is not > connected on the board? I asked myself the same question and even I thought in just remove that code. After some investigation, though, I saw that the UTMI+ specification [1] has two signals similar to ID signal (page 11), the AValid signal is used to indicate if the session for an A-peripheral is valid and the BValid signal that is used to indicate if the session for a B-peripheral is valid. I suppose that use of one or the other matters in some cases, but AFAICT this is not used and I didn't see any binding using it. Maybe someone else can give us more clues on the importance or not of this property? [1] https://www.nxp.com/docs/en/brochure/UTMI-PLUS-SPECIFICATION.pdf Enric > > > Heiko > >
Hi Enric, Am Mittwoch, 15. August 2018, 13:08:00 CEST schrieb Enric Balletbo i Serra: > On 15/08/18 12:29, Heiko Stuebner wrote: > > Am Mittwoch, 15. August 2018, 11:59:32 CEST schrieb Enric Balletbo i Serra: > >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for > >> rk3399") introduces two new properties. The extcon property is used to > >> detect the cable-state, and the rockchip,utmi-avalid is used to indicate > >> which register should be used to detect the vbus state. > >> > >> Document these properties in the documentation binding. > >> > >> Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [...] > >> @@ -45,6 +46,8 @@ Required properties (port (child) node): > >> Optional properties: > >> - phy-supply : phandle to a regulator that provides power to VBUS. > >> See ./phy-bindings.txt for details. > >> + - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. > >> + Otherwise, use the bvalid register. > > > > Not having looked to deeply into the usb2 phy, this might raise questions > > on why this is a hardware-description? Is this needed when something is not > > connected on the board? > > I asked myself the same question and even I thought in just remove that code. > > After some investigation, though, I saw that the UTMI+ specification [1] has two > signals similar to ID signal (page 11), the AValid signal is used to indicate if > the session for an A-peripheral is valid and the BValid signal that is used to > indicate if the session for a B-peripheral is valid. I suppose that use of one > or the other matters in some cases, but AFAICT this is not used and I didn't see > any binding using it. > > Maybe someone else can give us more clues on the importance or not of this property? so I've looked in mainline, chromeos-4.4 and the Rockchip vendor-kernel and the only board using that property at all is the rk3399-evb-rev1 and -rev2 in the vendor kernel. The existence of a further -rev3 (which also looks way better cared for compared rev1+2) indicates that the older ones are probably some sort of preproduction models, where some wiring (on the soc or board) may have gone wrong. So while I would keep all the avalid settings in the driver, we could just drop reading that property quietly - as Rob wrote some days ago "it's only an incompatible change if someone notices" [0] and from the above it doesn't look like it ;-) . Heiko [0] https://www.spinics.net/lists/devicetree/msg243978.html
On Wed, Aug 15, 2018 at 11:59:32AM +0200, Enric Balletbo i Serra wrote: > Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for > rk3399") introduces two new properties. The extcon property is used to > detect the cable-state, and the rockchip,utmi-avalid is used to indicate > which register should be used to detect the vbus state. > > Document these properties in the documentation binding. > > Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > index 074a7b3b0425..2d4808d3920b 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > @@ -23,6 +23,7 @@ Optional properties: > register files". When set driver will request its > phandle as one companion-grf for some special SoCs > (e.g RV1108). > + - extcon : phandle to the extcon device for the otg phy. extcon is not a good binding. The usb connector binding should be used instead for new users. Rob
Hi Rob, On 16/08/18 00:21, Rob Herring wrote: > On Wed, Aug 15, 2018 at 11:59:32AM +0200, Enric Balletbo i Serra wrote: >> Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for >> rk3399") introduces two new properties. The extcon property is used to >> detect the cable-state, and the rockchip,utmi-avalid is used to indicate >> which register should be used to detect the vbus state. >> >> Document these properties in the documentation binding. >> >> Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> --- >> >> .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> index 074a7b3b0425..2d4808d3920b 100644 >> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >> @@ -23,6 +23,7 @@ Optional properties: >> register files". When set driver will request its >> phandle as one companion-grf for some special SoCs >> (e.g RV1108). >> + - extcon : phandle to the extcon device for the otg phy. > > extcon is not a good binding. The usb connector binding should be used > instead for new users. > Ok, although the extcon thing is implemented in the driver, so I was trying to just describe how is implemented now, looks like nobody is using it apart from me (patches not upstreamed yet). I suppose switch to the usb connector binding will imply some driver modifications. I will take a look. Thanks, Enric > Rob >
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt index 074a7b3b0425..2d4808d3920b 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt @@ -23,6 +23,7 @@ Optional properties: register files". When set driver will request its phandle as one companion-grf for some special SoCs (e.g RV1108). + - extcon : phandle to the extcon device for the otg phy. Required nodes : a sub-node is required for each port the phy provides. The sub-node name is used to identify host or otg port, @@ -45,6 +46,8 @@ Required properties (port (child) node): Optional properties: - phy-supply : phandle to a regulator that provides power to VBUS. See ./phy-bindings.txt for details. + - rockchip,utmi-avalid : boolean, use the avalid register to get vbus status. + Otherwise, use the bvalid register. Example:
Commit 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") introduces two new properties. The extcon property is used to detect the cable-state, and the rockchip,utmi-avalid is used to indicate which register should be used to detect the vbus state. Document these properties in the documentation binding. Fixes: 98898f3bc83c8 ("phy: rockchip-inno-usb2: support otg-port for rk3399") Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 3 +++ 1 file changed, 3 insertions(+)