diff mbox series

mmc: renesas_sdhi_internal_dmac: add R8A77970 to whitelist

Message ID fd225e1d-5215-df96-055a-07c9a14f41e7@cogentembedded.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series mmc: renesas_sdhi_internal_dmac: add R8A77970 to whitelist | expand

Commit Message

Sergei Shtylyov Aug. 18, 2018, 6:08 p.m. UTC
I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
has a single SDHI core anyway, so can't be  a subject to the known RX DMA
errata...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo.

 drivers/mmc/host/renesas_sdhi_internal_dmac.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Wolfram Sang Aug. 20, 2018, 4:42 p.m. UTC | #1
On Sat, Aug 18, 2018 at 09:08:26PM +0300, Sergei Shtylyov wrote:
> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
> errata...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Nit: some strange double spaces and '...' in the commit message:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

And out of interest: was this an HS400 eMMC memory?

Thanks!

> ---
> This patch is against the 'next' branch of Ulf Hansson's 'mmc.git' repo.
> 
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> ===================================================================
> --- mmc.orig/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> +++ mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
> @@ -293,6 +293,7 @@ static const struct soc_device_attribute
>  	{ .soc_id = "r8a7795" },
>  	{ .soc_id = "r8a7796" },
>  	{ .soc_id = "r8a77965" },
> +	{ .soc_id = "r8a77970" },
>  	{ .soc_id = "r8a77980" },
>  	{ .soc_id = "r8a77995" },
>  	{ /* sentinel */ }
Sergei Shtylyov Aug. 20, 2018, 5:18 p.m. UTC | #2
On 08/20/2018 07:42 PM, Wolfram Sang wrote:

>> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
>> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
>> errata...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Nit: some strange double spaces and '...' in the commit message:

   Why are you so hostile to ...? :-)

> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> And out of interest: was this an HS400 eMMC memory?

   I ndon';t have the datasheet handy but I don't think it matters -- the board
only supplies 3.3V on both chip's voltage inputs...

> Thanks!

MBR, Sergei
Wolfram Sang Aug. 20, 2018, 5:24 p.m. UTC | #3
> > Nit: some strange double spaces and '...' in the commit message:
> 
>    Why are you so hostile to ...? :-)

To me, it has a meaning: either something is to be continued or the
sentence is intentionaly left open end, so the reader needs to complete
it. I see neither fit here and I don't see any extra value over '.'

Congrats, you got me bike-shedding.

>    I ndon';t have the datasheet handy but I don't think it matters -- the board
> only supplies 3.3V on both chip's voltage inputs...

Okay. Pity, would have liked another test report for HS400.
Sergei Shtylyov Aug. 20, 2018, 7:44 p.m. UTC | #4
On 08/20/2018 07:42 PM, Wolfram Sang wrote:

>> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
>> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
>> errata...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Nit: some strange double spaces and '...' in the commit message:
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

   Should I repost? Or you'd squash the fouble spaces and ellipsis while applying?

   BTW, will this patch go into the next or fixes branch? (I remember Ulf wanted to
stick the analogous R8A77980 patch into fixes.)

MBR, Sergei
Wolfram Sang Aug. 20, 2018, 8:07 p.m. UTC | #5
On Mon, Aug 20, 2018 at 10:44:18PM +0300, Sergei Shtylyov wrote:
> On 08/20/2018 07:42 PM, Wolfram Sang wrote:
> 
> >> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
> >> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
> >> errata...
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > 
> > Nit: some strange double spaces and '...' in the commit message:
> > 
> > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
>    Should I repost? Or you'd squash the fouble spaces and ellipsis while applying?
> 
>    BTW, will this patch go into the next or fixes branch? (I remember Ulf wanted to
> stick the analogous R8A77980 patch into fixes.)

I'll leave all these questions to Ulf.
Sergei Shtylyov Aug. 20, 2018, 8:15 p.m. UTC | #6
On 08/20/2018 11:07 PM, Wolfram Sang wrote:

>>>> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
>>>> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
>>>> errata...
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> Nit: some strange double spaces and '...' in the commit message:
>>>
>>> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>
>>    Should I repost? Or you'd squash the fouble spaces and ellipsis while applying?
>>
>>    BTW, will this patch go into the next or fixes branch? (I remember Ulf wanted to
>> stick the analogous R8A77980 patch into fixes.)
> 
> I'll leave all these questions to Ulf.

   Sorry, I forgot you don't have a separate repo.

MBR, Sergei
Ulf Hansson Aug. 22, 2018, 9:48 a.m. UTC | #7
On 20 August 2018 at 21:44, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 08/20/2018 07:42 PM, Wolfram Sang wrote:
>
>>> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
>>> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
>>> errata...
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> Nit: some strange double spaces and '...' in the commit message:
>>
>> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
>    Should I repost? Or you'd squash the fouble spaces and ellipsis while applying?

No need to repost, I have amended the change.

>
>    BTW, will this patch go into the next or fixes branch? (I remember Ulf wanted to
> stick the analogous R8A77980 patch into fixes.)

Don't recall, but decided to queue this for v4.20. Please tell if you
want me to do otherwise.

Kind regards
Uffe
Simon Horman Aug. 22, 2018, 11:41 a.m. UTC | #8
On Sat, Aug 18, 2018 at 09:08:26PM +0300, Sergei Shtylyov wrote:
> I've successfully tested eMMC  on the V3H Starter Kit board. R8A77970 SoC
> has a single SDHI core anyway, so can't be  a subject to the known RX DMA
> errata...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff mbox series

Patch

Index: mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
===================================================================
--- mmc.orig/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ mmc/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -293,6 +293,7 @@  static const struct soc_device_attribute
 	{ .soc_id = "r8a7795" },
 	{ .soc_id = "r8a7796" },
 	{ .soc_id = "r8a77965" },
+	{ .soc_id = "r8a77970" },
 	{ .soc_id = "r8a77980" },
 	{ .soc_id = "r8a77995" },
 	{ /* sentinel */ }