| Message ID | 20180818195855.13429-1-masneyb@onstation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: input: pwm-vibrator: correct pwm-names in example | expand |
On Sat, Aug 18, 2018 at 03:58:55PM -0400, Brian Masney wrote: > In the example for the pwm-vibrator bindings, pwm8 is the direction pin, > and pwm9 is the enable pin. The pwm-names on the vibrator node has these > two values swapped. This patch corrects the values for pwm-names. > > Signed-off-by: Brian Masney <masneyb@onstation.org> > --- > arch/arm/boot/dts/omap4-droid4-xt894.dts is actual implementation for > the example and it is correct. > > Documentation/devicetree/bindings/input/pwm-vibrator.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt > index 09145d18491d..2731cbb7e8d7 100644 > --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt > +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt > @@ -60,7 +60,7 @@ Example from Motorola Droid 4: > compatible = "pwm-vibrator"; > pwms = <&pwm8 0 1000000000 0>, > <&pwm9 0 1000000000 0>; > - pwm-names = "enable", "direction"; > + pwm-names = "direction", "enable"; As enable is required and direction is optional, enable should come first. So fix the pwms property instead. (And perhaps make the binding more explicit as to what the order should be. > direction-duty-cycle-ns = <1000000000>; > }; > }; > -- > 2.17.1 >
diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt index 09145d18491d..2731cbb7e8d7 100644 --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt @@ -60,7 +60,7 @@ Example from Motorola Droid 4: compatible = "pwm-vibrator"; pwms = <&pwm8 0 1000000000 0>, <&pwm9 0 1000000000 0>; - pwm-names = "enable", "direction"; + pwm-names = "direction", "enable"; direction-duty-cycle-ns = <1000000000>; }; };
In the example for the pwm-vibrator bindings, pwm8 is the direction pin, and pwm9 is the enable pin. The pwm-names on the vibrator node has these two values swapped. This patch corrects the values for pwm-names. Signed-off-by: Brian Masney <masneyb@onstation.org> --- arch/arm/boot/dts/omap4-droid4-xt894.dts is actual implementation for the example and it is correct. Documentation/devicetree/bindings/input/pwm-vibrator.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)