| Message ID | 20180820202108.16912-1-vishal.l.verma@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [ndctl] ndctl, test: add UUID_LIBS for list_smart_dimm | expand |
> -----Original Message----- > From: Vishal Verma [mailto:vishal.l.verma@intel.com] > Sent: Tuesday, August 21, 2018 5:21 AM > To: linux-nvdimm@lists.01.org > Cc: Vishal Verma <vishal.l.verma@intel.com>; Qi, Fuli/斉 福利 > <qi.fuli@jp.fujitsu.com> > Subject: [ndctl PATCH] ndctl, test: add UUID_LIBS for list_smart_dimm > > Some environments automatically include the missing library dependency, and others > need it to be explicitly included. > > Link: https://github.com/pmem/ndctl/issues/66 > Cc: QI Fuli <qi.fuli@jp.fujitsu.com> > Fixes: d1941474111a ("ndctl, test: add a new unit test for monitor") > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > test/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/Makefile.am b/test/Makefile.am index c224eb7..50bb2e4 100644 > --- a/test/Makefile.am > +++ b/test/Makefile.am > @@ -162,4 +162,5 @@ list_smart_dimm_SOURCES = \ list_smart_dimm_LDADD = \ > $(LIBNDCTL_LIB) \ > $(JSON_LIBS) \ > + $(UUID_LIBS) \ > ../libutil.a Looks good to me. Reviewed-by: QI Fuli <qi.fuli@jp.fujitsu.com> Thank you very much. Qi > -- > 2.14.4 >
diff --git a/test/Makefile.am b/test/Makefile.am index c224eb7..50bb2e4 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -162,4 +162,5 @@ list_smart_dimm_SOURCES = \ list_smart_dimm_LDADD = \ $(LIBNDCTL_LIB) \ $(JSON_LIBS) \ + $(UUID_LIBS) \ ../libutil.a
Some environments automatically include the missing library dependency, and others need it to be explicitly included. Link: https://github.com/pmem/ndctl/issues/66 Cc: QI Fuli <qi.fuli@jp.fujitsu.com> Fixes: d1941474111a ("ndctl, test: add a new unit test for monitor") Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- test/Makefile.am | 1 + 1 file changed, 1 insertion(+)