diff mbox series

[9/9] arm64: dts: renesas: r8a774a1: Add FCPF and FCPV instances

Message ID 1535031788-19907-10-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive)
State New, archived
Headers show
Series Add more support for r8a774a1 | expand

Commit Message

Fabrizio Castro Aug. 23, 2018, 1:43 p.m. UTC
Add FCPF and FCPV instances to the r8a774a1 dtsi, similarly
to what was done for the r8a7796 with commits 41dbbf0c5 ("arm64: dts:
r8a7796: Add FCPF and FCPV instances"), 69490bc96 ("arm64: dts:
renesas: r8a7796: Point FDP1 via FCPF to IPMMU-VI0"), and cef942d0b
("arm64: dts: renesas: r8a7796: Point VSPI via FCPVI to IPMMU-VC0").

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 52 +++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

Comments

Sergei Shtylyov Aug. 24, 2018, 8:48 a.m. UTC | #1
Hello!

On 8/23/2018 4:43 PM, Fabrizio Castro wrote:

> Add FCPF and FCPV instances to the r8a774a1 dtsi, similarly
> to what was done for the r8a7796 with commits 41dbbf0c5 ("arm64: dts:
> r8a7796: Add FCPF and FCPV instances"), 69490bc96 ("arm64: dts:
> renesas: r8a7796: Point FDP1 via FCPF to IPMMU-VI0"), and cef942d0b
> ("arm64: dts: renesas: r8a7796: Point VSPI via FCPVI to IPMMU-VC0").

   Need to specify 12 hex digits of SHA1 when citing commits.

> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
[...]

MBR, Sergei
Fabrizio Castro Aug. 24, 2018, 9:26 a.m. UTC | #2
Hello Sergei,

Thank you for your feedback!

> Subject: Re: [PATCH 9/9] arm64: dts: renesas: r8a774a1: Add FCPF and FCPV instances
>
> Hello!
>
> On 8/23/2018 4:43 PM, Fabrizio Castro wrote:
>
> > Add FCPF and FCPV instances to the r8a774a1 dtsi, similarly
> > to what was done for the r8a7796 with commits 41dbbf0c5 ("arm64: dts:
> > r8a7796: Add FCPF and FCPV instances"), 69490bc96 ("arm64: dts:
> > renesas: r8a7796: Point FDP1 via FCPF to IPMMU-VI0"), and cef942d0b
> > ("arm64: dts: renesas: r8a7796: Point VSPI via FCPVI to IPMMU-VC0").
>
>    Need to specify 12 hex digits of SHA1 when citing commits.

I'll send a v2 to address that.

Thanks,
Fab

>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> [...]
>
> MBR, Sergei



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Fabrizio Castro Aug. 24, 2018, 9:33 a.m. UTC | #3
> -----Original Message-----
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 24 August 2018 10:30
> To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Geert Uytterhoeven <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju
> Das <biju.das@bp.renesas.com>
> Subject: [PATCH v2 9/9] arm64: dts: renesas: r8a774a1: Add FCPF and FCPV instances
>
> Add FCPF and FCPV instances to the r8a774a1 dtsi, similarly
> to what was done for the r8a7796 with commits 41dbbf0c5 ("arm64: dts:

Scratch that! Will send a v3!

> r8a7796: Add FCPF and FCPV instances"), 69490bc9665d ("arm64: dts:
> renesas: r8a7796: Point FDP1 via FCPF to IPMMU-VI0"), and cef942d0bd89
> ("arm64: dts: renesas: r8a7796: Point VSPI via FCPVI to IPMMU-VC0").
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> v1->v2:
> * moved SHA1 hex to 12 digits as per Sergei comment
>
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 52 +++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index f23bbfd..5b2ee60 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -1260,6 +1260,58 @@
>  resets = <&cpg 408>;
>  };
>
> +fcpf0: fcp@fe950000 {
> +compatible = "renesas,fcpf";
> +reg = <0 0xfe950000 0 0x200>;
> +clocks = <&cpg CPG_MOD 615>;
> +power-domains = <&sysc 14>;
> +resets = <&cpg 615>;
> +};
> +
> +fcpvb0: fcp@fe96f000 {
> +compatible = "renesas,fcpv";
> +reg = <0 0xfe96f000 0 0x200>;
> +clocks = <&cpg CPG_MOD 607>;
> +power-domains = <&sysc 14>;
> +resets = <&cpg 607>;
> +};
> +
> +fcpvd0: fcp@fea27000 {
> +compatible = "renesas,fcpv";
> +reg = <0 0xfea27000 0 0x200>;
> +clocks = <&cpg CPG_MOD 603>;
> +power-domains = <&sysc 32>;
> +resets = <&cpg 603>;
> +iommus = <&ipmmu_vi0 8>;
> +};
> +
> +fcpvd1: fcp@fea2f000 {
> +compatible = "renesas,fcpv";
> +reg = <0 0xfea2f000 0 0x200>;
> +clocks = <&cpg CPG_MOD 602>;
> +power-domains = <&sysc 32>;
> +resets = <&cpg 602>;
> +iommus = <&ipmmu_vi0 9>;
> +};
> +
> +fcpvd2: fcp@fea37000 {
> +compatible = "renesas,fcpv";
> +reg = <0 0xfea37000 0 0x200>;
> +clocks = <&cpg CPG_MOD 601>;
> +power-domains = <&sysc 32>;
> +resets = <&cpg 601>;
> +iommus = <&ipmmu_vi0 10>;
> +};
> +
> +fcpvi0: fcp@fe9af000 {
> +compatible = "renesas,fcpv";
> +reg = <0 0xfe9af000 0 0x200>;
> +clocks = <&cpg CPG_MOD 611>;
> +power-domains = <&sysc 14>;
> +resets = <&cpg 611>;
> +iommus = <&ipmmu_vc0 19>;
> +};
> +
>  prr: chipid@fff00044 {
>  compatible = "renesas,prr";
>  reg = <0 0xfff00044 0 4>;
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index f23bbfd..5b2ee60 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1260,6 +1260,58 @@ 
 			resets = <&cpg 408>;
 		};
 
+		fcpf0: fcp@fe950000 {
+			compatible = "renesas,fcpf";
+			reg = <0 0xfe950000 0 0x200>;
+			clocks = <&cpg CPG_MOD 615>;
+			power-domains = <&sysc 14>;
+			resets = <&cpg 615>;
+		};
+
+		fcpvb0: fcp@fe96f000 {
+			compatible = "renesas,fcpv";
+			reg = <0 0xfe96f000 0 0x200>;
+			clocks = <&cpg CPG_MOD 607>;
+			power-domains = <&sysc 14>;
+			resets = <&cpg 607>;
+		};
+
+		fcpvd0: fcp@fea27000 {
+			compatible = "renesas,fcpv";
+			reg = <0 0xfea27000 0 0x200>;
+			clocks = <&cpg CPG_MOD 603>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 603>;
+			iommus = <&ipmmu_vi0 8>;
+		};
+
+		fcpvd1: fcp@fea2f000 {
+			compatible = "renesas,fcpv";
+			reg = <0 0xfea2f000 0 0x200>;
+			clocks = <&cpg CPG_MOD 602>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 602>;
+			iommus = <&ipmmu_vi0 9>;
+		};
+
+		fcpvd2: fcp@fea37000 {
+			compatible = "renesas,fcpv";
+			reg = <0 0xfea37000 0 0x200>;
+			clocks = <&cpg CPG_MOD 601>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 601>;
+			iommus = <&ipmmu_vi0 10>;
+		};
+
+		fcpvi0: fcp@fe9af000 {
+			compatible = "renesas,fcpv";
+			reg = <0 0xfe9af000 0 0x200>;
+			clocks = <&cpg CPG_MOD 611>;
+			power-domains = <&sysc 14>;
+			resets = <&cpg 611>;
+			iommus = <&ipmmu_vc0 19>;
+		};
+
 		prr: chipid@fff00044 {
 			compatible = "renesas,prr";
 			reg = <0 0xfff00044 0 4>;