diff mbox series

[1/1] ARM: dts: imx6ul: Add weim node

Message ID 20180824163605.12521-1-sebastien.szymanski@armadeus.com (mailing list archive)
State New, archived
Headers show
Series [1/1] ARM: dts: imx6ul: Add weim node | expand

Commit Message

Sébastien Szymanski Aug. 24, 2018, 4:36 p.m. UTC
Add weim node for i.MX6UL SOC.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Fabio Estevam Aug. 24, 2018, 4:42 p.m. UTC | #1
Hi Sébastien,

On Fri, Aug 24, 2018 at 1:32 PM Sébastien Szymanski
<sebastien.szymanski@armadeus.com> wrote:
>
> Add weim node for i.MX6UL SOC.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 47a3453a4211..7b00efd93d18 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -912,6 +912,17 @@
>                                 reg = <0x021b0000 0x4000>;
>                         };
>
> +                       weim: weim@21b8000 {
> +                               #address-cells = <2>;
> +                               #size-cells = <1>;
> +                               compatible = "fsl,imx6ul-weim", "fsl,imx6q-weim";
> +                               reg = <0x021b8000 0x4000>;
> +                               interrupts = <0 14 IRQ_TYPE_LEVEL_HIGH>;

Looks good.

Only a minor nit: for consistency please use:
interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 47a3453a4211..7b00efd93d18 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -912,6 +912,17 @@ 
 				reg = <0x021b0000 0x4000>;
 			};
 
+			weim: weim@21b8000 {
+				#address-cells = <2>;
+				#size-cells = <1>;
+				compatible = "fsl,imx6ul-weim", "fsl,imx6q-weim";
+				reg = <0x021b8000 0x4000>;
+				interrupts = <0 14 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX6UL_CLK_EIM>;
+				fsl,weim-cs-gpr = <&gpr>;
+				status = "disabled";
+			};
+
 			ocotp: ocotp-ctrl@21bc000 {
 				#address-cells = <1>;
 				#size-cells = <1>;