diff mbox series

[v2,3/3] drivers/block/z2ram: use ioremap_wt() instead of __ioremap(_PAGE_WRITETHRU)

Message ID 48bcbeb8e5f57c958e6e0bc7a29feae44821901d.1535385970.git.christophe.leroy@c-s.fr (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] powerpc/32: Add ioremap_wt() | expand

Commit Message

Christophe Leroy Aug. 27, 2018, 4:10 p.m. UTC
_PAGE_WRITETHRU is a target specific flag. Prefer generic functions.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 v2: no change

 drivers/block/z2ram.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Geert Uytterhoeven Aug. 27, 2018, 4:42 p.m. UTC | #1
On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy
<christophe.leroy@c-s.fr> wrote:
> _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

From a Zorro bus point of view:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/drivers/block/z2ram.c
> +++ b/drivers/block/z2ram.c
> @@ -190,8 +190,7 @@ static int z2_open(struct block_device *bdev, fmode_t mode)
>                         vfree(vmalloc (size));
>                 }
>
> -               vaddr = (unsigned long) __ioremap (paddr, size,
> -                                                  _PAGE_WRITETHRU);
> +               vaddr = (unsigned long)ioremap_wt(paddr, size);
>
>  #else
>                 vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);

However, since the removal of APUS support, this file can no longer be
compiled on powerpc.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
index d0c5bc4e0703..cfbd70520eeb 100644
--- a/drivers/block/z2ram.c
+++ b/drivers/block/z2ram.c
@@ -190,8 +190,7 @@  static int z2_open(struct block_device *bdev, fmode_t mode)
 			vfree(vmalloc (size));
 		}
 
-		vaddr = (unsigned long) __ioremap (paddr, size, 
-						   _PAGE_WRITETHRU);
+		vaddr = (unsigned long)ioremap_wt(paddr, size);
 
 #else
 		vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);