mbox series

[0/3] lightnvm: pblk: support variable OOB size

Message ID 1535537370-10729-1-git-send-email-javier@cnexlabs.com (mailing list archive)
Headers show
Series lightnvm: pblk: support variable OOB size | expand

Message

Javier González Aug. 29, 2018, 10:09 a.m. UTC
This patchset adds pblk support for variable metadata sizes on the out
of bound area.

Igor, Marcin, you sent a patch some time ago implementing a similar
functionality, but it never got re-posted after review. Can you test
this and see if it works for your case? I did not implement support for
outlined metadata for the case where the reported OOB area is 0. It
should be pretty simple to do that on top of these patches though.

Thanks,
Javier

Javier González (3):
  lightnvm: use internal allocation for chunk log page
  lightnvm: do no update csecs and sos on 1.2
  lightnvm: pblk: support variable OOB size

 drivers/lightnvm/pblk-core.c     | 60 ++++++++++++++++++++++++++++++----------
 drivers/lightnvm/pblk-init.c     | 16 ++++++++++-
 drivers/lightnvm/pblk-map.c      | 19 +++++++++----
 drivers/lightnvm/pblk-read.c     | 55 ++++++++++++++++++++++--------------
 drivers/lightnvm/pblk-recovery.c | 34 ++++++++++++++++-------
 drivers/lightnvm/pblk.h          | 18 +++++++++---
 drivers/nvme/host/lightnvm.c     | 26 +++++++++++------
 7 files changed, 164 insertions(+), 64 deletions(-)

Comments

Igor Konopko Aug. 29, 2018, 2:51 p.m. UTC | #1
On 29.08.2018 12:09, Javier González wrote:
> This patchset adds pblk support for variable metadata sizes on the out
> of bound area.
> 
> Igor, Marcin, you sent a patch some time ago implementing a similar
> functionality, but it never got re-posted after review. Can you test
> this and see if it works for your case? I did not implement support for
> outlined metadata for the case where the reported OOB area is 0. It
> should be pretty simple to do that on top of these patches though.
> 

Sure, we will test that and let you know. I was busy last time and due 
to that I never repost it. I will do this on top of your patches, 
hopefully soon.

> Thanks,
> Javier
> 
> Javier González (3):
>    lightnvm: use internal allocation for chunk log page
>    lightnvm: do no update csecs and sos on 1.2
>    lightnvm: pblk: support variable OOB size
> 
>   drivers/lightnvm/pblk-core.c     | 60 ++++++++++++++++++++++++++++++----------
>   drivers/lightnvm/pblk-init.c     | 16 ++++++++++-
>   drivers/lightnvm/pblk-map.c      | 19 +++++++++----
>   drivers/lightnvm/pblk-read.c     | 55 ++++++++++++++++++++++--------------
>   drivers/lightnvm/pblk-recovery.c | 34 ++++++++++++++++-------
>   drivers/lightnvm/pblk.h          | 18 +++++++++---
>   drivers/nvme/host/lightnvm.c     | 26 +++++++++++------
>   7 files changed, 164 insertions(+), 64 deletions(-)
>
Javier Gonzalez Aug. 29, 2018, 7:57 p.m. UTC | #2
> On 29 Aug 2018, at 16.51, Igor Konopko <igor.j.konopko@intel.com> wrote:
> 
> 
> 
> On 29.08.2018 12:09, Javier González wrote:
>> This patchset adds pblk support for variable metadata sizes on the out
>> of bound area.
>> Igor, Marcin, you sent a patch some time ago implementing a similar
>> functionality, but it never got re-posted after review. Can you test
>> this and see if it works for your case? I did not implement support for
>> outlined metadata for the case where the reported OOB area is 0. It
>> should be pretty simple to do that on top of these patches though.
> 
> Sure, we will test that and let you know. I was busy last time and due
> to that I never repost it. I will do this on top of your patches,
> hopefully soon.
> 

Thanks Igor, this would be great.