diff mbox series

[01/10] clk: samsung: Remove excessive include

Message ID 20180829155046.29359-2-m.szyprowski@samsung.com (mailing list archive)
State Superseded, archived
Headers show
Series Cleanup suspend/resume code in Samsung clock drivers | expand

Commit Message

Marek Szyprowski Aug. 29, 2018, 3:50 p.m. UTC 
Exynos Audio SubSystem and Exynos3250 clock drivers don't use any syscore
function, so don't include linux/syscore_ops.h in their code.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/clk/samsung/clk-exynos-audss.c | 1 -
 drivers/clk/samsung/clk-exynos3250.c   | 1 -
 2 files changed, 2 deletions(-)

Comments

Chanwoo Choi Aug. 30, 2018, midnight UTC | #1 
On 2018년 08월 30일 00:50, Marek Szyprowski wrote:
> Exynos Audio SubSystem and Exynos3250 clock drivers don't use any syscore
> function, so don't include linux/syscore_ops.h in their code.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos-audss.c | 1 -
>  drivers/clk/samsung/clk-exynos3250.c   | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
> index f659c5cbf1d5..8f8a0f9fc842 100644
> --- a/drivers/clk/samsung/clk-exynos-audss.c
> +++ b/drivers/clk/samsung/clk-exynos-audss.c
> @@ -15,7 +15,6 @@
>  #include <linux/clk-provider.h>
>  #include <linux/of_address.h>
>  #include <linux/of_device.h>
> -#include <linux/syscore_ops.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
> diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
> index 27c9d23657b3..0e9a41a4cac8 100644
> --- a/drivers/clk/samsung/clk-exynos3250.c
> +++ b/drivers/clk/samsung/clk-exynos3250.c
> @@ -12,7 +12,6 @@
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/platform_device.h>
> -#include <linux/syscore_ops.h>
>  
>  #include <dt-bindings/clock/exynos3250.h>
>  
> 

I tested kernel build. There are no warning and break.

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Krzysztof Kozlowski Aug. 30, 2018, 6:34 a.m. UTC | #2 
On Wed, 29 Aug 2018 at 17:51, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Exynos Audio SubSystem and Exynos3250 clock drivers don't use any syscore
> function, so don't include linux/syscore_ops.h in their code.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos-audss.c | 1 -
>  drivers/clk/samsung/clk-exynos3250.c   | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
index f659c5cbf1d5..8f8a0f9fc842 100644
--- a/drivers/clk/samsung/clk-exynos-audss.c
+++ b/drivers/clk/samsung/clk-exynos-audss.c
@@ -15,7 +15,6 @@ 
 #include <linux/clk-provider.h>
 #include <linux/of_address.h>
 #include <linux/of_device.h>
-#include <linux/syscore_ops.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
diff --git a/drivers/clk/samsung/clk-exynos3250.c b/drivers/clk/samsung/clk-exynos3250.c
index 27c9d23657b3..0e9a41a4cac8 100644
--- a/drivers/clk/samsung/clk-exynos3250.c
+++ b/drivers/clk/samsung/clk-exynos3250.c
@@ -12,7 +12,6 @@ 
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/platform_device.h>
-#include <linux/syscore_ops.h>
 
 #include <dt-bindings/clock/exynos3250.h>