| Message ID | 20180816100628.26428-5-david@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mm/memory_hotplug: online/offline_pages refactorings | expand |
LGTM Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com> On 8/16/18 6:06 AM, David Hildenbrand wrote: > Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM). > online_pages_range() can never fail. > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > mm/memory_hotplug.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 3dc6d2a309c2..bbbd16f9d877 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ > setup_zone_pageset(zone); > } > > - ret = walk_system_ram_range(pfn, nr_pages, &onlined_pages, > - online_pages_range); > - if (ret) { > - if (need_zonelists_rebuild) > - zone_pcp_reset(zone); > - goto failed_addition; > - } > + walk_system_ram_range(pfn, nr_pages, &onlined_pages, > + online_pages_range); > > zone->present_pages += onlined_pages; > >
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 3dc6d2a309c2..bbbd16f9d877 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ setup_zone_pageset(zone); } - ret = walk_system_ram_range(pfn, nr_pages, &onlined_pages, - online_pages_range); - if (ret) { - if (need_zonelists_rebuild) - zone_pcp_reset(zone); - goto failed_addition; - } + walk_system_ram_range(pfn, nr_pages, &onlined_pages, + online_pages_range); zone->present_pages += onlined_pages;
Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM). online_pages_range() can never fail. Signed-off-by: David Hildenbrand <david@redhat.com> --- mm/memory_hotplug.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)