| Message ID | 08b528ddc26adcb57539b1ac9d352850d7d80bfb.1533815718.git.amit.kucheria@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | Another round of tsens cleanups | expand |
On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote: > c(1) + x(1) was actually meant to be c(1) * x(1). > > While we're at it, add some brackets to make it nicer to read. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index cc553f0952c5..751104213d08 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -152,7 +152,7 @@ Optional property: > Elem size: one cell the sensors listed in the thermal-sensors property. > Elem type: signed Coefficients defaults to 1, in case this property > is not specified. A simple linear polynomial is used: > - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. > + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn. > > The coefficients are ordered and they match with sensors > by means of sensor ID. Additional coefficients are Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote: > c(1) + x(1) was actually meant to be c(1) * x(1). > > While we're at it, add some brackets to make it nicer to read. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Rob Herring <robh@kernel.org>
On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote: > c(1) + x(1) was actually meant to be c(1) * x(1). > > While we're at it, add some brackets to make it nicer to read. > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index cc553f0952c5..751104213d08 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -152,7 +152,7 @@ Optional property: > Elem size: one cell the sensors listed in the thermal-sensors property. > Elem type: signed Coefficients defaults to 1, in case this property > is not specified. A simple linear polynomial is used: > - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. > + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn. To be honest, I would prefer if this looks like: + Z = c0 * x0 + c1 * x1 + ... + c(n-1) * x(n-1) + cn. The extra bracketing seams unnecessary confusion > > The coefficients are ordered and they match with sensors > by means of sensor ID. Additional coefficients are > -- > 2.17.1 >
On 25/08/2018 01:24, Eduardo Valentin wrote: > On Thu, Aug 09, 2018 at 06:02:34PM +0530, Amit Kucheria wrote: >> c(1) + x(1) was actually meant to be c(1) * x(1). >> >> While we're at it, add some brackets to make it nicer to read. >> >> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt >> index cc553f0952c5..751104213d08 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -152,7 +152,7 @@ Optional property: >> Elem size: one cell the sensors listed in the thermal-sensors property. >> Elem type: signed Coefficients defaults to 1, in case this property >> is not specified. A simple linear polynomial is used: >> - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. >> + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn. > > To be honest, I would prefer if this looks like: > + Z = c0 * x0 + c1 * x1 + ... + c(n-1) * x(n-1) + cn. > > The extra bracketing seams unnecessary confusion I agree, the brackets don't change the computation ordering, they are pointless.
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index cc553f0952c5..751104213d08 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -152,7 +152,7 @@ Optional property: Elem size: one cell the sensors listed in the thermal-sensors property. Elem type: signed Coefficients defaults to 1, in case this property is not specified. A simple linear polynomial is used: - Z = c0 * x0 + c1 + x1 + ... + c(n-1) * x(n-1) + cn. + Z = (c0 * x0) + (c1 * x1) + ... + (c(n-1) * x(n-1)) + cn. The coefficients are ordered and they match with sensors by means of sensor ID. Additional coefficients are
c(1) + x(1) was actually meant to be c(1) * x(1). While we're at it, add some brackets to make it nicer to read. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- Documentation/devicetree/bindings/thermal/thermal.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)