| Message ID | 20180831214756.15129-1-dev@pp3345.net (mailing list archive) |
|---|---|
| State | Under Review |
| Headers | show |
| Series | Input: synaptics - enable RMI on ThinkPad T560 | expand |
From: Yussuf Khalil <dev@pp3345.net> Subject: [PATCH] Input: synaptics - enable RMI on ThinkPad T560 Date: Fri, 31 Aug 2018 23:47:56 +0200 > Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O This commit is not yet in Linus' tree; it's only in Wolfram Sang's i2c tree. In particular, it appeared *after* the pull request for 4.19-rc1. See: * https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-current @Yussuf Khalil: Does it work after several suspend/resume? Thanks for your present report, and beforehand for the answer. Regards, Teika > ports not reserved for SMBus"), enabling RMI on the T560 would cause > the touchpad to stop working after resuming from suspend. Now that > this issue is fixed, RMI can be enabled safely and works fine. > > Signed-off-by: Yussuf Khalil <dev@pp3345.net> > --- > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 55d33500d55e..8f0e8ba63bbc 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = { > "LEN0048", /* X1 Carbon 3 */ > "LEN0046", /* X250 */ > "LEN004a", /* W541 */ > + "LEN005e", /* T560 */ > "LEN0071", /* T480 */ > "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ > "LEN0073", /* X1 Carbon G5 (Elantech) */ > -- > 2.17.1 >
> This commit is not yet in Linus' tree; it's only in Wolfram Sang's i2c tree. In particular, it appeared *after* the pull request for 4.19-rc1. Well, no. The commit is here in Linus' master branch: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7fd6d98b89f382d414e1db528e29a67bbd749457 It was pulled yesterday: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=754cf4b2432dfea0f925a0b760506a9c97c8f00b So the commit will be included in 4.19-rc2. > @Yussuf Khalil: Does it work after several suspend/resume? Thanks for your present report, and beforehand for the answer. Yes, everything works perfectly fine for me. I've been using the i801 patch for about two weeks already with many suspend-resume cycles. > From: Yussuf Khalil <dev@pp3345.net> > Subject: [PATCH] Input: synaptics - enable RMI on ThinkPad T560 > Date: Fri, 31 Aug 2018 23:47:56 +0200 > >> Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O > > This commit is not yet in Linus' tree; it's only in Wolfram Sang's i2c tree. In particular, it appeared *after* the pull request for 4.19-rc1. See: > > * https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/log/?h=i2c/for-current > > @Yussuf Khalil: Does it work after several suspend/resume? Thanks for your present report, and beforehand for the answer. > > Regards, > Teika > >> ports not reserved for SMBus"), enabling RMI on the T560 would cause >> the touchpad to stop working after resuming from suspend. Now that >> this issue is fixed, RMI can be enabled safely and works fine. >> >> Signed-off-by: Yussuf Khalil <dev@pp3345.net> >> --- >> drivers/input/mouse/synaptics.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c >> index 55d33500d55e..8f0e8ba63bbc 100644 >> --- a/drivers/input/mouse/synaptics.c >> +++ b/drivers/input/mouse/synaptics.c >> @@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = { >> "LEN0048", /* X1 Carbon 3 */ >> "LEN0046", /* X250 */ >> "LEN004a", /* W541 */ >> + "LEN005e", /* T560 */ >> "LEN0071", /* T480 */ >> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ >> "LEN0073", /* X1 Carbon G5 (Elantech) */ >> -- >> 2.17.1 >>
On Fri, Aug 31, 2018 at 11:58 PM Yussuf Khalil <dev@pp3345.net> wrote: > > Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O > ports not reserved for SMBus"), enabling RMI on the T560 would cause > the touchpad to stop working after resuming from suspend. Now that > this issue is fixed, RMI can be enabled safely and works fine. Glad to see some progress has been made :) > > Signed-off-by: Yussuf Khalil <dev@pp3345.net> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > --- > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 55d33500d55e..8f0e8ba63bbc 100644 > --- a/drivers/input/mouse/synaptics.c > +++ b/drivers/input/mouse/synaptics.c > @@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = { > "LEN0048", /* X1 Carbon 3 */ > "LEN0046", /* X250 */ > "LEN004a", /* W541 */ > + "LEN005e", /* T560 */ > "LEN0071", /* T480 */ > "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ > "LEN0073", /* X1 Carbon G5 (Elantech) */ > -- > 2.17.1 >
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 55d33500d55e..8f0e8ba63bbc 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = { "LEN0048", /* X1 Carbon 3 */ "LEN0046", /* X250 */ "LEN004a", /* W541 */ + "LEN005e", /* T560 */ "LEN0071", /* T480 */ "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */ "LEN0073", /* X1 Carbon G5 (Elantech) */
Before commit 7fd6d98b89f3 ("i2c: i801: Allow ACPI AML access I/O ports not reserved for SMBus"), enabling RMI on the T560 would cause the touchpad to stop working after resuming from suspend. Now that this issue is fixed, RMI can be enabled safely and works fine. Signed-off-by: Yussuf Khalil <dev@pp3345.net> --- drivers/input/mouse/synaptics.c | 1 + 1 file changed, 1 insertion(+)