| Message ID | 20180904121027.24031-13-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | R-Car D3/E3 display support (with LVDS PLL) | expand |
On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > tree. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> My Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> are still valid. Gr{oetje,eeting}s, Geert
Hi Laurent, Geert, On Tue, Sep 04, 2018 at 04:32:32PM +0200, Geert Uytterhoeven wrote: > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > > tree. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > My > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > are still valid. I was about to send a v2 with these and the slight change Geert suggested on the ch[0-7] list. Would you prefer me to drop it from my v2 series and re-base HDMI and CVBS enablement for E3 on top of this series? Thanks j > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Geert, On Tuesday, 4 September 2018 17:32:32 EEST Geert Uytterhoeven wrote: > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > > tree. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > My > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > are still valid. Sorry for not picking them up. I've included the patch in my series as it's a necessary prerequisite, but was expecting it to be merged separately.
Hi Jacopo, On Tuesday, 4 September 2018 17:49:53 EEST jacopo mondi wrote: > On Tue, Sep 04, 2018 at 04:32:32PM +0200, Geert Uytterhoeven wrote: > > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart wrote: > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> > >> Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > >> tree. > >> > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > > My > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > are still valid. > > I was about to send a v2 with these and the slight change Geert > suggested on the ch[0-7] list. > > Would you prefer me to drop it from my v2 series and re-base HDMI and > CVBS enablement for E3 on top of this series? Please don't. We don't know which series will go in first. In any case I'd like to fast-track this patch, so if you could post an updated version on its own it would be helpful.
On Wed, Sep 05, 2018 at 04:53:26PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Tuesday, 4 September 2018 17:49:53 EEST jacopo mondi wrote: > > On Tue, Sep 04, 2018 at 04:32:32PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart wrote: > > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> > > >> Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 device > > >> tree. > > >> > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > > > > My > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > > are still valid. > > > > I was about to send a v2 with these and the slight change Geert > > suggested on the ch[0-7] list. > > > > Would you prefer me to drop it from my v2 series and re-base HDMI and > > CVBS enablement for E3 on top of this series? > > Please don't. We don't know which series will go in first. In any case I'd > like to fast-track this patch, so if you could post an updated version on its > own it would be helpful. The patch should appear in the next branch later today. Hopefully that will make everyones lives just that little bit easier.
Hi Simon, On Thursday, 6 September 2018 12:26:46 EEST Simon Horman wrote: > On Wed, Sep 05, 2018 at 04:53:26PM +0300, Laurent Pinchart wrote: > > On Tuesday, 4 September 2018 17:49:53 EEST jacopo mondi wrote: > > > On Tue, Sep 04, 2018 at 04:32:32PM +0200, Geert Uytterhoeven wrote: > > > > On Tue, Sep 4, 2018 at 2:10 PM Laurent Pinchart wrote: > > > >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > >> > > > >> Add device nodes for I2C ch{0,1,2,3,4,5,6,7} to R-Car E3 R8A77990 > > > >> device > > > >> tree. > > > >> > > > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > > > > > > My > > > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > > > > are still valid. > > > > > > I was about to send a v2 with these and the slight change Geert > > > suggested on the ch[0-7] list. > > > > > > Would you prefer me to drop it from my v2 series and re-base HDMI and > > > CVBS enablement for E3 on top of this series? > > > > Please don't. We don't know which series will go in first. In any case I'd > > like to fast-track this patch, so if you could post an updated version on > > its own it would be helpful. > > The patch should appear in the next branch later today. > Hopefully that will make everyones lives just that little > bit easier. Thank you very much.
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index ae89260baad9..abb14af76c0e 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -14,6 +14,17 @@ #address-cells = <2>; #size-cells = <2>; + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + }; + cpus { #address-cells = <1>; #size-cells = <0>; @@ -185,6 +196,118 @@ resets = <&cpg 906>; }; + i2c0: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe6500000 0 0x40>; + interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 931>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 931>; + i2c-scl-internal-delay-ns = <110>; + status = "disabled"; + }; + + i2c1: i2c@e6508000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe6508000 0 0x40>; + interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 930>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 930>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + + i2c2: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe6510000 0 0x40>; + interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 929>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 929>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + + i2c3: i2c@e66d0000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe66d0000 0 0x40>; + interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 928>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 928>; + i2c-scl-internal-delay-ns = <110>; + status = "disabled"; + }; + + i2c4: i2c@e66d8000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe66d8000 0 0x40>; + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 927>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 927>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + + i2c5: i2c@e66e0000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe66e0000 0 0x40>; + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 919>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 919>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + + i2c6: i2c@e66e8000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe66e8000 0 0x40>; + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 918>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 918>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + + i2c7: i2c@e6690000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,i2c-r8a77990", + "renesas,rcar-gen3-i2c"; + reg = <0 0xe6690000 0 0x40>; + interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 1003>; + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; + resets = <&cpg 1003>; + i2c-scl-internal-delay-ns = <6>; + status = "disabled"; + }; + pfc: pin-controller@e6060000 { compatible = "renesas,pfc-r8a77990"; reg = <0 0xe6060000 0 0x508>;