| Message ID | 20180903133434.58188-2-icenowy@aosc.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Changes A64 HDMI PHY compatible to R40 | expand |
On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: > By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux > introduced in R40, although it has two PLL-VIDEOs. > > Change the A64 HDMI PHY binding to R40 one. > > This binding is introduced in v4.19, which is still in RC stage, so we > have change to fix it. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> That doesn't make much sense. The A64 doesn't have any particular reason to behave like the R40, and the R40 can definitely use a different compatible if it has a different behaviour. But I don't see *why* the A64 not behaving like the R40 is a justification to remove the A64 compatible. Especially when the R40 was released later. Add a new compatible, and leave the A64 compatible alone. Maxime
于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard <maxime.ripard@bootlin.com> 写到: >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux >> introduced in R40, although it has two PLL-VIDEOs. >> >> Change the A64 HDMI PHY binding to R40 one. >> >> This binding is introduced in v4.19, which is still in RC stage, so >we >> have change to fix it. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > >That doesn't make much sense. The A64 doesn't have any particular >reason to behave like the R40, and the R40 can definitely use a >different compatible if it has a different behaviour. But I don't see >*why* the A64 not behaving like the R40 is a justification to remove >the A64 compatible. Especially when the R40 was released later. > >Add a new compatible, and leave the A64 compatible alone. But the behavior of A64 compatible will change from double PLL to single PLL, because the A64 HDMI PHY is proven to have no double PLL. Should I then change the A64 compatible behavior and import R40 compatible at the same time? In addition maybe I can just drop A64 compatible, and let A64 use H3 one. Then I will add a R40 compatible to catch dual PLL behavior. > >Maxime
On Wed, Sep 05, 2018 at 03:46:41PM +0800, Icenowy Zheng wrote: > > > 于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard <maxime.ripard@bootlin.com> 写到: > >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: > >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux > >> introduced in R40, although it has two PLL-VIDEOs. > >> > >> Change the A64 HDMI PHY binding to R40 one. > >> > >> This binding is introduced in v4.19, which is still in RC stage, so > >we > >> have change to fix it. > >> > >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > > > >That doesn't make much sense. The A64 doesn't have any particular > >reason to behave like the R40, and the R40 can definitely use a > >different compatible if it has a different behaviour. But I don't see > >*why* the A64 not behaving like the R40 is a justification to remove > >the A64 compatible. Especially when the R40 was released later. > > > >Add a new compatible, and leave the A64 compatible alone. > > But the behavior of A64 compatible will change from double > PLL to single PLL, because the A64 HDMI PHY is proven > to have no double PLL. > > Should I then change the A64 compatible behavior and import R40 > compatible at the same time? I don't see why you should do both at the same time. Fix the A64, and add the support for the R40, those are two orthogonal changes. > In addition maybe I can just drop A64 compatible, and let A64 > use H3 one. No, that break the backward compatibility. Maxime
于 2018年9月5日 GMT+08:00 下午3:56:01, Maxime Ripard <maxime.ripard@bootlin.com> 写到: >On Wed, Sep 05, 2018 at 03:46:41PM +0800, Icenowy Zheng wrote: >> >> >> 于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard ><maxime.ripard@bootlin.com> 写到: >> >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: >> >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux >> >> introduced in R40, although it has two PLL-VIDEOs. >> >> >> >> Change the A64 HDMI PHY binding to R40 one. >> >> >> >> This binding is introduced in v4.19, which is still in RC stage, >so >> >we >> >> have change to fix it. >> >> >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> > >> >That doesn't make much sense. The A64 doesn't have any particular >> >reason to behave like the R40, and the R40 can definitely use a >> >different compatible if it has a different behaviour. But I don't >see >> >*why* the A64 not behaving like the R40 is a justification to remove >> >the A64 compatible. Especially when the R40 was released later. >> > >> >Add a new compatible, and leave the A64 compatible alone. >> >> But the behavior of A64 compatible will change from double >> PLL to single PLL, because the A64 HDMI PHY is proven >> to have no double PLL. >> >> Should I then change the A64 compatible behavior and import R40 >> compatible at the same time? > >I don't see why you should do both at the same time. Fix the A64, and >add the support for the R40, those are two orthogonal changes. Then how to deal with double PLL support? Make them temporarily dead during 4.19? > >> In addition maybe I can just drop A64 compatible, and let A64 >> use H3 one. > >No, that break the backward compatibility. As I said A64 compatible is just introduced in 4.19-rc. So if we finish before 4.19.0 we break nothing. > >Maxime
On Wed, Sep 05, 2018 at 04:05:18PM +0800, Icenowy Zheng wrote: > > > 于 2018年9月5日 GMT+08:00 下午3:56:01, Maxime Ripard <maxime.ripard@bootlin.com> 写到: > >On Wed, Sep 05, 2018 at 03:46:41PM +0800, Icenowy Zheng wrote: > >> > >> > >> 于 2018年9月5日 GMT+08:00 下午3:14:35, Maxime Ripard > ><maxime.ripard@bootlin.com> 写到: > >> >On Mon, Sep 03, 2018 at 09:34:32PM +0800, Icenowy Zheng wrote: > >> >> By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux > >> >> introduced in R40, although it has two PLL-VIDEOs. > >> >> > >> >> Change the A64 HDMI PHY binding to R40 one. > >> >> > >> >> This binding is introduced in v4.19, which is still in RC stage, > >so > >> >we > >> >> have change to fix it. > >> >> > >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > >> > > >> >That doesn't make much sense. The A64 doesn't have any particular > >> >reason to behave like the R40, and the R40 can definitely use a > >> >different compatible if it has a different behaviour. But I don't > >see > >> >*why* the A64 not behaving like the R40 is a justification to remove > >> >the A64 compatible. Especially when the R40 was released later. > >> > > >> >Add a new compatible, and leave the A64 compatible alone. > >> > >> But the behavior of A64 compatible will change from double > >> PLL to single PLL, because the A64 HDMI PHY is proven > >> to have no double PLL. > >> > >> Should I then change the A64 compatible behavior and import R40 > >> compatible at the same time? > > > >I don't see why you should do both at the same time. Fix the A64, and > >add the support for the R40, those are two orthogonal changes. > > Then how to deal with double PLL support? Make them temporarily > dead during 4.19? Well, if the PHY doesn't use two PLL, don't use it, ever. Why does it have to be temporary?
diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index f8773ecb7525..de6814a5aba3 100644 --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt @@ -103,7 +103,7 @@ Required properties: - compatible: value must be one of: * allwinner,sun8i-a83t-hdmi-phy * allwinner,sun8i-h3-hdmi-phy - * allwinner,sun50i-a64-hdmi-phy + * allwinner,sun8i-r40-hdmi-phy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the HDMI PHY * bus: the HDMI PHY interface clock @@ -112,9 +112,9 @@ Required properties: - resets: phandle to the reset controller driving the PHY - reset-names: must be "phy" -H3 and A64 HDMI PHY require additional clocks: +H3 and R40 HDMI PHY require additional clocks: - pll-0: parent of phy clock - - pll-1: second possible phy clock parent (A64 only) + - pll-1: second possible phy clock parent (R40 only) TV Encoder ----------
By experiment, the A64 HDMi PHY doesn't support the PLL-VIDEO mux introduced in R40, although it has two PLL-VIDEOs. Change the A64 HDMI PHY binding to R40 one. This binding is introduced in v4.19, which is still in RC stage, so we have change to fix it. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- .../devicetree/bindings/display/sunxi/sun4i-drm.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)