diff mbox series

firmware/dmc/icl: Add MODULE_FIRMWARE()

Message ID 1536177035-28877-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show
Series firmware/dmc/icl: Add MODULE_FIRMWARE() | expand

Commit Message

Srivatsa, Anusha Sept. 5, 2018, 7:50 p.m. UTC
Add missing MODULE_FIRMWARE while loading DMC on Icelake.

Rebased on top of https://patchwork.freedesktop.org/patch/246153/

Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rodrigo Vivi Sept. 5, 2018, 11:10 p.m. UTC | #1
On Wed, Sep 05, 2018 at 12:50:35PM -0700, Anusha Srivatsa wrote:
> Add missing MODULE_FIRMWARE while loading DMC on Icelake.
> 
> Rebased on top of https://patchwork.freedesktop.org/patch/246153/

What about a Fixes after the patch gets pushed?

so with message removed or replaced by a proper fixes

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 4aa8f3d..d48186e 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -35,6 +35,7 @@
>   */
>  
>  #define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_ICL);
>  #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>  
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 4aa8f3d..d48186e 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -35,6 +35,7 @@ 
  */
 
 #define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
+MODULE_FIRMWARE(I915_CSR_ICL);
 #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
 
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"