| Message ID | 1532006789-32454-4-git-send-email-bpothuno@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Johannes Berg |
| Headers | show |
On Thu, 2018-07-19 at 18:56 +0530, Balaji Pothunoori wrote: > > > - if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map)) > + if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map) || > + test_bit(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FLAGS, ar->wmi.svc_map)) > wiphy_ext_feature_set(ar->hw->wiphy, > - NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); > + NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); You should use the new name, and fix indentation. johannes
On 2018-08-29 14:23, Johannes Berg wrote: > On Thu, 2018-07-19 at 18:56 +0530, Balaji Pothunoori wrote: >> >> >> - if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map)) >> + if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map) || >> + test_bit(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FLAGS, >> ar->wmi.svc_map)) >> wiphy_ext_feature_set(ar->hw->wiphy, >> - NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); >> + NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); > > You should use the new name, and fix indentation. > > johannes Sure, i will send updated v3 patch.
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1ebd9c63..70d8489 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -8410,9 +8410,10 @@ int ath10k_mac_register(struct ath10k *ar) wiphy_ext_feature_set(ar->hw->wiphy, NL80211_EXT_FEATURE_SET_SCAN_DWELL); - if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map)) + if (test_bit(WMI_SERVICE_TX_DATA_ACK_RSSI, ar->wmi.svc_map) || + test_bit(WMI_SERVICE_HTT_MGMT_TX_COMP_VALID_FLAGS, ar->wmi.svc_map)) wiphy_ext_feature_set(ar->hw->wiphy, - NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); + NL80211_EXT_FEATURE_DATA_ACK_SIGNAL_SUPPORT); /* * on LL hardware queues are managed entirely by the FW
Adding WMI service check for management tx ack rssi support; this is done to maintain common avg ack signal in user level for both data and management tx ack packet. Tested on QCA4019(fw version-10.4-3.2.1-00063). Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org> --- Note: This patch depends on following patch https://patchwork.kernel.org/patch/10343153/ drivers/net/wireless/ath/ath10k/mac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)