[v2,3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

Commit Message

Matthias Kaehlcke Sept. 6, 2018, 9:04 p.m. UTC

Add a channel node for the die temperature to the ADC.

Signed-off-by: Matthias Kaehlcke <[e-mail]>
Reviewed-by: Douglas Anderson <[e-mail]>
Signed-off-by: Matthias Kaehlcke <[e-mail]>
--
Changes in v2:
- none
---
 arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Doug Anderson Sept. 6, 2018, 9:10 p.m. UTC | #1

Hi,

On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <[e-mail]> wrote:
> Add a channel node for the die temperature to the ADC.
>
> Signed-off-by: Matthias Kaehlcke <[e-mail]>
> Reviewed-by: Douglas Anderson <[e-mail]>
> Signed-off-by: Matthias Kaehlcke <[e-mail]>

Double-SoB?

...presumably Andy can remove that when he lands and doesn't need a re-post...

-Doug

Matthias Kaehlcke Sept. 6, 2018, 9:22 p.m. UTC | #2

On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote:
> Hi,
> 
> On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <[e-mail]> wrote:
> > Add a channel node for the die temperature to the ADC.
> >
> > Signed-off-by: Matthias Kaehlcke <[e-mail]>
> > Reviewed-by: Douglas Anderson <[e-mail]>
> > Signed-off-by: Matthias Kaehlcke <[e-mail]>
> 
> Double-SoB?

I must have run 'amend' with '-s' out of habit, which wasn't the right
thing to do in this case :/

> ...presumably Andy can remove that when he lands and doesn't need a re-post...

Andy, in case you need me to repost let me know.

Thanks

Matthias

Jonathan Cameron Sept. 8, 2018, 2:15 p.m. UTC | #3

On Thu, 6 Sep 2018 14:22:06 -0700
Matthias Kaehlcke <[e-mail]> wrote:

> On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote:
> > Hi,
> > 
> > On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke <[e-mail]> wrote:  
> > > Add a channel node for the die temperature to the ADC.
> > >
> > > Signed-off-by: Matthias Kaehlcke <[e-mail]>
> > > Reviewed-by: Douglas Anderson <[e-mail]>
> > > Signed-off-by: Matthias Kaehlcke <[e-mail]>  
> > 
> > Double-SoB?  
> 
> I must have run 'amend' with '-s' out of habit, which wasn't the right
> thing to do in this case :/
> 
> > ...presumably Andy can remove that when he lands and doesn't need a re-post...  
> 
> Andy, in case you need me to repost let me know.
Slightly worse than that (as was patch 1).  You accidentally used
-- rather than --- to separate the change log.  So I ended up with

Signed-off-by: M..
Reviewed-by: ..
Signed-off-by: M..
--
Changelog

Signed-off-by: J....

Good think the double signed off was raised as chances are I wouldn't
have notice it.

Jonathan
> 
> Thanks
> 
> Matthias

Patch

diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 41593ebbea2c..d18d4f260fbe 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -19,6 +19,11 @@ 
 			#address-cells = <1>;
 			#size-cells = <0>;
 			#io-channel-cells = <1>;
+
+			die-temp {
+				reg = <ADC5_DIE_TEMP>;
+				label = "die_temp";
+			};
 		};
 
 		pm8998_gpio: gpios@c000 {