mbox series

[0/3] media: use irqsave() in USB's complete callback + remove local_irq_save

Message ID 20180910092000.14693-1-bigeasy@linutronix.de (mailing list archive)
Headers show
Series media: use irqsave() in USB's complete callback + remove local_irq_save | expand

Message

Sebastian Andrzej Siewior Sept. 10, 2018, 9:19 a.m. UTC
I've been looking at my queue and compared to v4.19-rc3. As it turns
out, everything was merged except for

	media: em28xx-audio: use irqsave() in USB's complete
	media: tm6000: use irqsave() in USB's complete callback

I haven't seen any reply to those two patches (like asking for changes)
so I assume that those two just fell through the cracks.

The last one is the final removal of the local_irq_save() statement once
all drivers were audited & fixed.

Sebastian

Comments

Mauro Carvalho Chehab Sept. 10, 2018, 9:25 a.m. UTC | #1
Em Mon, 10 Sep 2018 11:19:57 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:

> I've been looking at my queue and compared to v4.19-rc3. As it turns
> out, everything was merged except for
> 
> 	media: em28xx-audio: use irqsave() in USB's complete
> 	media: tm6000: use irqsave() in USB's complete callback
> 
> I haven't seen any reply to those two patches (like asking for changes)
> so I assume that those two just fell through the cracks.
> 
> The last one is the final removal of the local_irq_save() statement once
> all drivers were audited & fixed.

I suspect that it is better to merge it via sound tree, due to
patch 3/3.

So, for patches 1 and 2:

Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

Thanks,
Mauro
Sebastian Andrzej Siewior Sept. 10, 2018, 9:30 a.m. UTC | #2
On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote:
> Em Mon, 10 Sep 2018 11:19:57 +0200
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:
> 
> > I've been looking at my queue and compared to v4.19-rc3. As it turns
> > out, everything was merged except for
> > 
> > 	media: em28xx-audio: use irqsave() in USB's complete
> > 	media: tm6000: use irqsave() in USB's complete callback
> > 
> > I haven't seen any reply to those two patches (like asking for changes)
> > so I assume that those two just fell through the cracks.
> > 
> > The last one is the final removal of the local_irq_save() statement once
> > all drivers were audited & fixed.
> 
> I suspect that it is better to merge it via sound tree, due to
> patch 3/3.

Sound? Sound like alsa? Or did you mean USB?

> So, for patches 1 and 2:
> 
> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

Thank you. It would be nice if this would hit Linus in this cycle :)

> Thanks,
> Mauro

Sebastian
Greg Kroah-Hartman Sept. 10, 2018, 1:37 p.m. UTC | #3
On Mon, Sep 10, 2018 at 11:30:30AM +0200, Sebastian Andrzej Siewior wrote:
> On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote:
> > Em Mon, 10 Sep 2018 11:19:57 +0200
> > Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:
> > 
> > > I've been looking at my queue and compared to v4.19-rc3. As it turns
> > > out, everything was merged except for
> > > 
> > > 	media: em28xx-audio: use irqsave() in USB's complete
> > > 	media: tm6000: use irqsave() in USB's complete callback
> > > 
> > > I haven't seen any reply to those two patches (like asking for changes)
> > > so I assume that those two just fell through the cracks.
> > > 
> > > The last one is the final removal of the local_irq_save() statement once
> > > all drivers were audited & fixed.
> > 
> > I suspect that it is better to merge it via sound tree, due to
> > patch 3/3.
> 
> Sound? Sound like alsa? Or did you mean USB?
> 
> > So, for patches 1 and 2:
> > 
> > Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> 
> Thank you. It would be nice if this would hit Linus in this cycle :)

I can take these all through my tree, but no, it's too late for 4.19 for
the last patch. Sorry, this is a 4.20 change as it touches the core USB code.

thanks,

greg k-h
Mauro Carvalho Chehab Sept. 10, 2018, 3:58 p.m. UTC | #4
Em Mon, 10 Sep 2018 15:37:58 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> escreveu:

> On Mon, Sep 10, 2018 at 11:30:30AM +0200, Sebastian Andrzej Siewior wrote:
> > On 2018-09-10 06:25:57 [-0300], Mauro Carvalho Chehab wrote:  
> > > Em Mon, 10 Sep 2018 11:19:57 +0200
> > > Sebastian Andrzej Siewior <bigeasy@linutronix.de> escreveu:
> > >   
> > > > I've been looking at my queue and compared to v4.19-rc3. As it turns
> > > > out, everything was merged except for
> > > > 
> > > > 	media: em28xx-audio: use irqsave() in USB's complete
> > > > 	media: tm6000: use irqsave() in USB's complete callback
> > > > 
> > > > I haven't seen any reply to those two patches (like asking for changes)
> > > > so I assume that those two just fell through the cracks.
> > > > 
> > > > The last one is the final removal of the local_irq_save() statement once
> > > > all drivers were audited & fixed.  
> > > 
> > > I suspect that it is better to merge it via sound tree, due to
> > > patch 3/3.  
> > 
> > Sound? Sound like alsa? Or did you mean USB?

Yeah, it makes more sense to merge at via USB tree. Feel free to add it there.

Regards,
Mauro