diff mbox series

drm/i915/chv: Update csc coefficient matrix during modeset

Message ID 1536584482-12894-1-git-send-email-raviraj.p.sitaram@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/chv: Update csc coefficient matrix during modeset | expand

Commit Message

Sitaram, Raviraj P Sept. 10, 2018, 1:01 p.m. UTC
From: P Raviraj Sitaram <raviraj.p.sitaram@intel.com>

During modeset, previously configured csc coefficient matrix,if any, will
not persist. This can result in blank screen as csc mode will be programmed
while loading LUT but csc coefficient matrix remains unprogrammed.

Signed-off-by: P Raviraj Sitaram <raviraj.p.sitaram@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ville Syrjälä Sept. 10, 2018, 1:42 p.m. UTC | #1
On Mon, Sep 10, 2018 at 06:31:22PM +0530, raviraj.p.sitaram@intel.com wrote:
> From: P Raviraj Sitaram <raviraj.p.sitaram@intel.com>
> 
> During modeset, previously configured csc coefficient matrix,if any, will
> not persist. This can result in blank screen as csc mode will be programmed
> while loading LUT but csc coefficient matrix remains unprogrammed.
> 
> Signed-off-by: P Raviraj Sitaram <raviraj.p.sitaram@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index b2bab57cd113..5029c0daa994 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6014,6 +6014,9 @@ static void valleyview_crtc_enable(struct intel_crtc_state *pipe_config,
>  
>  	i9xx_set_pipeconf(intel_crtc);
>  
> +	if (IS_CHERRYVIEW(dev_priv))
> +		intel_color_set_csc(&pipe_config->base);
> +

No need for the platform check.

>  	intel_crtc->active = true;
>  
>  	intel_set_cpu_fifo_underrun_reporting(dev_priv, pipe, true);
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vania Toperich Sept. 10, 2018, 1:52 p.m. UTC | #2
tested-by: Vania Toperich <Vania@bergehenegouwen.com<mailto:Vania@bergehenegouwen.com>>


This patch series does the following:
- Adds concept of CRTC output format, which indicates if a CRTC is
  driving RGB/YCBCR4:4:4/YCBCR4:2:0 or other outputs.
- Sets RGB as default output for all displays.
- Enables YCBCR4:4:4/4:2:0 outputs for LSPCON displays
- Drives these outputs on LSPCON using this CRTC output framework.

Sharma, Shashank (2):
  drm/i915: Check LSPCON vendor OUI
  drm/i915: Write AVI infoframes for MCA LSPCON

Shashank Sharma (6):
  drm/i915: Introduce CRTC output format
  drm/i915: Add CRTC output format YCBCR 4:2:0
  drm/i915: Add CRTC output format YCBCR 4:4:4
  drm/i915: Add AVI infoframe support for LSPCON
  drm/i915: Write AVI infoframes for Parade LSPCON
  drm/i915: Add YCBCR 4:2:0/4:4:4 support for LSPCON

 drivers/gpu/drm/i915/i915_reg.h      |   2 +
 drivers/gpu/drm/i915/intel_color.c   |   3 +-
 drivers/gpu/drm/i915/intel_crt.c     |   3 +
 drivers/gpu/drm/i915/intel_ddi.c     |  28 ++-
 drivers/gpu/drm/i915/intel_display.c | 104 ++++++++---
 drivers/gpu/drm/i915/intel_dp.c      |   5 +
 drivers/gpu/drm/i915/intel_dp_mst.c  |   1 +
 drivers/gpu/drm/i915/intel_drv.h     |  39 +++-
 drivers/gpu/drm/i915/intel_dvo.c     |   1 +
 drivers/gpu/drm/i915/intel_hdmi.c    |  24 ++-
 drivers/gpu/drm/i915/intel_lspcon.c  | 348 +++++++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/intel_lvds.c    |   2 +
 drivers/gpu/drm/i915/intel_panel.c   |   2 +-
 drivers/gpu/drm/i915/intel_sdvo.c    |   1 +
 drivers/gpu/drm/i915/intel_tv.c      |   1 +
 drivers/gpu/drm/i915/vlv_dsi.c       |   1 +
 16 files changed, 507 insertions(+), 58 deletions(-)

--
2.7.4

Vania Toperich
IT Specialist



[cid:imaged8560e.PNG@55e6a927.4c8f743d] <http://vbhi.com>


T: <tel:> , M: +31 6 15097042<tel:+31%206%2015097042>
<mailto:>Vania@bergehenegouwen.com<mailto:Vania@bergehenegouwen.com>
vbhi.com<http://vbhi.com>





Pieter Braaijweg 1, 1114 AJ Amsterdam-Duivendrecht
T: +31 20 7993700<tel:+31207993700>, F: +31 20 8907777<tel:+31208907777>, COC: Leiden 28065487, Privacy statement<https://vbhi.com/privacy/>



[cid:imaged22777.PNG@13c0b9a5.42a2e922] <https://www.linkedin.com/company/van-berge-henegouwen-installaties>   [cid:imagefb6205.PNG@c35fcf52.4d8f3037]  <https://twitter.com/VBHLivingTech>   [cid:imageb89948.PNG@b740f58b.42981778]  <https://www.facebook.com/VBHLivingTech>   [cid:imagef80601.PNG@4fa957ea.4580c4f4]  <https://plus.google.com/113245007887789538337/about>   [cid:imagef23541.PNG@fb0907b0.47b1ca4c]  <https://www.google.nl/maps/dir/''/van+berge+henegouwen+maps/@52.3298669,4.8901335,13z/data=!3m1!4b1!4m8!4m7!1m0!1m5!1m1!1s0x47c5c34be9daf4b5:0xd2941955ae73781a!2m2!1d4.9251527!2d52.3298721>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<span style="font-size: 16px; font-family: 'Intel Clear', sans-serif; color: rgb(31, 73, 125);" class="">tested-by:<span class="apple-converted-space">&nbsp;</span></span><span style="font-size: 11pt; font-family: Calibri, sans-serif;" class="">Vania Toperich &lt;<a href="mailto:Vania@bergehenegouwen.com" style="color: purple;" class="">Vania@bergehenegouwen.com</a>&gt;</span><br class="">
<br class="">
<div class=""><br class="">
<div class="">This patch series does the following:</div>
<div class="">- Adds concept of CRTC output format, which indicates if a CRTC is</div>
<div class="">&nbsp; driving RGB/YCBCR4:4:4/YCBCR4:2:0 or other outputs.</div>
<div class="">- Sets RGB as default output for all displays.</div>
<div class="">- Enables YCBCR4:4:4/4:2:0 outputs for LSPCON displays</div>
<div class="">- Drives these outputs on LSPCON using this CRTC output framework.</div>
<div class=""><br class="">
</div>
<div class="">Sharma, Shashank (2):</div>
<div class="">&nbsp; drm/i915: Check LSPCON vendor OUI</div>
<div class="">&nbsp; drm/i915: Write AVI infoframes for MCA LSPCON</div>
<div class=""><br class="">
</div>
<div class="">Shashank Sharma (6):</div>
<div class="">&nbsp; drm/i915: Introduce CRTC output format</div>
<div class="">&nbsp; drm/i915: Add CRTC output format YCBCR 4:2:0</div>
<div class="">&nbsp; drm/i915: Add CRTC output format YCBCR 4:4:4</div>
<div class="">&nbsp; drm/i915: Add AVI infoframe support for LSPCON</div>
<div class="">&nbsp; drm/i915: Write AVI infoframes for Parade LSPCON</div>
<div class="">&nbsp; drm/i915: Add YCBCR 4:2:0/4:4:4 support for LSPCON</div>
<div class=""><br class="">
</div>
<div class="">&nbsp;drivers/gpu/drm/i915/i915_reg.h &nbsp; &nbsp; &nbsp;| &nbsp; 2 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_color.c &nbsp; | &nbsp; 3 &#43;-</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_crt.c &nbsp; &nbsp; | &nbsp; 3 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_ddi.c &nbsp; &nbsp; | &nbsp;28 &#43;&#43;-</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_display.c | 104 &#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;---</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_dp.c &nbsp; &nbsp; &nbsp;| &nbsp; 5 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_dp_mst.c &nbsp;| &nbsp; 1 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_drv.h &nbsp; &nbsp; | &nbsp;39 &#43;&#43;&#43;-</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_dvo.c &nbsp; &nbsp; | &nbsp; 1 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_hdmi.c &nbsp; &nbsp;| &nbsp;24 &#43;&#43;-</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_lspcon.c &nbsp;| 348 &#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;--</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_lvds.c &nbsp; &nbsp;| &nbsp; 2 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_panel.c &nbsp; | &nbsp; 2 &#43;-</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_sdvo.c &nbsp; &nbsp;| &nbsp; 1 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/intel_tv.c &nbsp; &nbsp; &nbsp;| &nbsp; 1 &#43;</div>
<div class="">&nbsp;drivers/gpu/drm/i915/vlv_dsi.c &nbsp; &nbsp; &nbsp; | &nbsp; 1 &#43;</div>
<div class="">&nbsp;16 files changed, 507 insertions(&#43;), 58 deletions(-)</div>
<div class=""><br class="">
</div>
<div class="">--&nbsp;</div>
<div class="">2.7.4</div>
</div>
<table width="100%" bgcolor="#ffffff" border="0" cellpadding="0" cellspacing="0" style="font-family: Arial, sans-serif; font-size: 13px; color: #000000;">
<tbody>
<tr border="0" cellspacing="0" cellpadding="0">
<td style="font-size: 13px;color: #48444D;line-height: 15px;">
<p style="font-size: 13px;color: #48444D;line-height: 15px;"><span style="font-size: 16px;color: #000000;line-height: 18px; font-weight:bold;">Vania Toperich</span><br>
IT Specialist</p>
</td>
</tr>
<tr height="15">
<td></td>
</tr>
<tr border="0" cellspacing="0" cellpadding="0">
<td><a href="http://vbhi.com" target="_blank" style="text-decoration: none; color: #9B9B9B"><img src="cid:imaged8560e.PNG@55e6a927.4c8f743d" style="border-style: none;">
</a></td>
</tr>
<tr height="10">
<td></td>
</tr>
<tr border="0" cellspacing="0" cellpadding="0">
<td style="font-size: 13px;color: #9B9B9B;line-height: 19px;">
<p style="font-size: 13px;color: #9B9B9B;line-height: 19px;">T: <a href="tel:" style="color: #9B9B9B; text-decoration: none;">
</a>, M: <a href="tel:&#43;31 6 15097042" style="color: #9B9B9B; text-decoration: none;">
&#43;31 6 15097042</a><br>
<a href="mailto:" style="color: #9B9B9B; text-decoration: none;"><span style="color:#9B9B9B;text-decoration:none;"></a><a href="mailto:Vania@bergehenegouwen.com" title="Click to send email to Vania Toperich" target="" style="color:#9B9B9B;text-decoration:none;"><span style="color:#9B9B9B; text-decoration:none;">Vania@bergehenegouwen.com</span></a></span><br>
<a href="http://vbhi.com" target="_blank" style="color: #9B9B9B; text-decoration: none;">vbhi.com</a></p>
</td>
</tr>
<tr height="10">
<td></td>
</tr>
<tr height="10">
<td></td>
</tr>
<tr height="10">
<td style="border-top: 1px dotted #9B9B9B;"></td>
</tr>
<tr border="0" cellspacing="0" cellpadding="0">
<td style="font-size: 11px;color: #9B9B9B;line-height: 17px;">
<p style="font-size: 11px;color: #9B9B9B;line-height: 17px;">Pieter Braaijweg 1, 1114 AJ Amsterdam-Duivendrecht<br>
T: <a href="tel:&#43;31207993700" style="color: #9B9B9B; text-decoration: none;">&#43;31 20 7993700</a>, F:
<a href="tel:&#43;31208907777" style="color: #9B9B9B; text-decoration: none;">&#43;31 20 8907777</a>, COC: Leiden 28065487,
<a href="https://vbhi.com/privacy/" style="color: #9B9B9B; text-decoration: none;">
Privacy statement</a></p>
</td>
</tr>
<tr height="10">
<td></td>
</tr>
<tr border="0" cellspacing="0" cellpadding="0">
<td><a href="https://www.linkedin.com/company/van-berge-henegouwen-installaties" target="_blank" style="text-decoration: none; color: #9B9B9B"><img src="cid:imaged22777.PNG@13c0b9a5.42a2e922" style="border-style: none;">
</a>&nbsp; <a href="https://twitter.com/VBHLivingTech" target="_blank" style="text-decoration: none; color: #9B9B9B">
<img src="cid:imagefb6205.PNG@c35fcf52.4d8f3037" style="border-style: none;"> </a>
&nbsp; <a href="https://www.facebook.com/VBHLivingTech" target="_blank" style="text-decoration: none; color: #9B9B9B">
<img src="cid:imageb89948.PNG@b740f58b.42981778" style="border-style: none;"> </a>
&nbsp; <a href="https://plus.google.com/113245007887789538337/about" target="_blank" style="text-decoration: none; color: #9B9B9B">
<img src="cid:imagef80601.PNG@4fa957ea.4580c4f4" style="border-style: none;"> </a>
&nbsp; <a href="https://www.google.nl/maps/dir/''/van&#43;berge&#43;henegouwen&#43;maps/@52.3298669,4.8901335,13z/data=!3m1!4b1!4m8!4m7!1m0!1m5!1m1!1s0x47c5c34be9daf4b5:0xd2941955ae73781a!2m2!1d4.9251527!2d52.3298721" target="_blank" style="text-decoration: none; color: #9B9B9B">
<img src="cid:imagef23541.PNG@fb0907b0.47b1ca4c" style="border-style: none;"> </a>
</td>
</tr>
</tbody>
</table>
</body>
</html>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b2bab57cd113..5029c0daa994 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -6014,6 +6014,9 @@  static void valleyview_crtc_enable(struct intel_crtc_state *pipe_config,
 
 	i9xx_set_pipeconf(intel_crtc);
 
+	if (IS_CHERRYVIEW(dev_priv))
+		intel_color_set_csc(&pipe_config->base);
+
 	intel_crtc->active = true;
 
 	intel_set_cpu_fifo_underrun_reporting(dev_priv, pipe, true);